diff options
| -rwxr-xr-x | scripts/add_copyright.py | 2 | ||||
| -rwxr-xr-x | scripts/check_bad_style.sh | 1 | ||||
| -rw-r--r-- | scripts/clang-tidy.h | 1 | ||||
| -rwxr-xr-x | scripts/clang_tidy_rules.py | 2 | ||||
| -rwxr-xr-x | scripts/format_doxygen.py | 2 | ||||
| -rwxr-xr-x | scripts/include_functions_kernels.py | 2 | ||||
| -rw-r--r-- | tests/AssetsLibrary.h | 1 | ||||
| -rw-r--r-- | tests/SConscript | 1 | ||||
| -rw-r--r-- | tests/validation/UNIT/Utils.cpp | 20 |
9 files changed, 2 insertions, 30 deletions
diff --git a/scripts/add_copyright.py b/scripts/add_copyright.py index a9d4929db8..ad1dab6f40 100755 --- a/scripts/add_copyright.py +++ b/scripts/add_copyright.py @@ -1,6 +1,4 @@ #!/usr/bin/env python3 -#FIXME: Remove this file before the release - import glob import os.path diff --git a/scripts/check_bad_style.sh b/scripts/check_bad_style.sh index c9fa57f8eb..e5dc15c218 100755 --- a/scripts/check_bad_style.sh +++ b/scripts/check_bad_style.sh @@ -1,5 +1,4 @@ #!/bin/bash -#FIXME: Remove this file before the release set -e diff --git a/scripts/clang-tidy.h b/scripts/clang-tidy.h index 318b85ed58..b3705122c6 100644 --- a/scripts/clang-tidy.h +++ b/scripts/clang-tidy.h @@ -1,5 +1,4 @@ #include <arm_neon.h> -//FIXME: Remove this file before the release inline float16x4_t vrsqrts_f16 (float16x4_t, float16x4_t) { diff --git a/scripts/clang_tidy_rules.py b/scripts/clang_tidy_rules.py index fce84b0b9c..d6deee9b68 100755 --- a/scripts/clang_tidy_rules.py +++ b/scripts/clang_tidy_rules.py @@ -1,6 +1,4 @@ #!/usr/bin/env python -#FIXME: Remove this file before the release - import os import re import sys diff --git a/scripts/format_doxygen.py b/scripts/format_doxygen.py index e18f24eb52..5882958fc5 100755 --- a/scripts/format_doxygen.py +++ b/scripts/format_doxygen.py @@ -1,6 +1,4 @@ #!/usr/bin/env python3 -# FIXME: Remove before the release - import os.path import re import sys diff --git a/scripts/include_functions_kernels.py b/scripts/include_functions_kernels.py index 80d1fb28e9..074f7949b8 100755 --- a/scripts/include_functions_kernels.py +++ b/scripts/include_functions_kernels.py @@ -1,6 +1,4 @@ #!/usr/bin/env python -#FIXME: Remove this file before the release - import glob import collections import os diff --git a/tests/AssetsLibrary.h b/tests/AssetsLibrary.h index afdf714ff1..7e2a042e9d 100644 --- a/tests/AssetsLibrary.h +++ b/tests/AssetsLibrary.h @@ -742,7 +742,6 @@ void AssetsLibrary::fill_layer_data(T &&tensor, std::string name) const Window window; window.use_tensor_dimensions(tensor.shape()); - //FIXME : Replace with normal loop execute_window_loop(window, [&](const Coordinates & id) { stream.read(reinterpret_cast<char *>(tensor(id)), tensor.element_size()); diff --git a/tests/SConscript b/tests/SConscript index a128d399f8..9f6392653c 100644 --- a/tests/SConscript +++ b/tests/SConscript @@ -31,6 +31,7 @@ SConscript('./framework/SConscript', duplicate=0) variables = [ #FIXME: Remove before release! BoolVariable("benchmark_examples", "Build benchmark examples programs", True), + #FIXME Switch the following two options to False before releasing BoolVariable("validation_tests", "Build validation test programs", True), BoolVariable("benchmark_tests", "Build benchmark test programs", True), ("test_filter", "Pattern to specify the tests' filenames to be compiled", "*.cpp") diff --git a/tests/validation/UNIT/Utils.cpp b/tests/validation/UNIT/Utils.cpp index b73edb1fb8..3980674170 100644 --- a/tests/validation/UNIT/Utils.cpp +++ b/tests/validation/UNIT/Utils.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017 ARM Limited. + * Copyright (c) 2017-2018 ARM Limited. * * SPDX-License-Identifier: MIT * @@ -74,15 +74,6 @@ DATA_TEST_CASE(RoundFloatToNearestUp, framework::DatasetMode::ALL, zip(framework ARM_COMPUTE_EXPECT(round(value, RoundingPolicy::TO_NEAREST_UP) == result, framework::LogLevel::ERRORS); } -//FIXME: Negative tests only work in debug mode -#if 0 -DISABLED_DATA_TEST_CASE(Index2CoordFail, framework::DatasetMode::ALL, zip(framework::dataset::make("Shape", { TensorShape{}, TensorShape{ 2U }, TensorShape{ 2U } }), framework::dataset::make("Index", { 0, -1, 2 })), - shape, index) -{ - ARM_COMPUTE_ASSERT(index2coord(shape, index)); -} -#endif /* 0 */ - DATA_TEST_CASE(Coord2Index, framework::DatasetMode::ALL, zip(zip(framework::dataset::make("Shape", { TensorShape{ 1U }, TensorShape{ 2U }, TensorShape{ 2U, 3U } }), framework::dataset::make("Coordinates", { Coordinates{ 0 }, Coordinates{ 1 }, Coordinates{ 0, 1 } })), framework::dataset::make("Index", { 0, 1, 2 })), @@ -93,14 +84,5 @@ DATA_TEST_CASE(Coord2Index, framework::DatasetMode::ALL, zip(zip(framework::data ARM_COMPUTE_EXPECT(index == ref_index, framework::LogLevel::ERRORS); } -//FIXME: Negative tests only work in debug mode -#if 0 -DISABLED_DATA_TEST_CASE(Coord2IndexFail, framework::DatasetMode::ALL, zip(framework::dataset::make("Shape", { TensorShape{}, TensorShape{ 2U } }), framework::dataset::make("Coordinates", { Coordinates{ 0 }, Coordinates{} })), - shape, coordinate) -{ - ARM_COMPUTE_ASSERT(coord2index(shape, coordinate)); -} -#endif /* 0 */ - TEST_SUITE_END() TEST_SUITE_END() |