diff options
| author | Georgios Pinitas <georgios.pinitas@arm.com> | 2019-03-25 14:06:14 +0000 |
|---|---|---|
| committer | Georgios Pinitas <georgios.pinitas@arm.com> | 2019-03-27 15:49:14 +0000 |
| commit | f52cd78acdedc9b4e2342daf2ca65578a6da28e1 (patch) | |
| tree | 85850cc536a4360668a8a6185f691065fdb66c00 /utils | |
| parent | 8cf8c1123440c2002ee108d1949529bf21eac944 (diff) | |
| download | ComputeLibrary-f52cd78acdedc9b4e2342daf2ca65578a6da28e1.tar.gz | |
COMPMID-1995: Minor code fixes.
-Remove FIXMEs and link to tickets.
-Pass large object by const reference.
-Implement copy assignment operator for Window.
Change-Id: I975223ac42ec424f153569a8c963f29e6b86ad29
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Reviewed-on: https://review.mlplatform.org/c/899
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Diffstat (limited to 'utils')
| -rw-r--r-- | utils/GraphUtils.h | 6 | ||||
| -rw-r--r-- | utils/TypePrinter.h | 1 | ||||
| -rw-r--r-- | utils/command_line/CommandLineParser.h | 4 |
3 files changed, 5 insertions, 6 deletions
diff --git a/utils/GraphUtils.h b/utils/GraphUtils.h index 47656766a6..4ae484f430 100644 --- a/utils/GraphUtils.h +++ b/utils/GraphUtils.h @@ -21,8 +21,8 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ -#ifndef __ARM_COMPUTE_GRAPH_UTILS_H__ -#define __ARM_COMPUTE_GRAPH_UTILS_H__ +#ifndef __ARM_COMPUTE_UTILS_GRAPH_UTILS_H__ +#define __ARM_COMPUTE_UTILS_GRAPH_UTILS_H__ #include "arm_compute/core/PixelValue.h" #include "arm_compute/core/Utils.h" @@ -601,4 +601,4 @@ inline graph::Target set_target_hint(int target) } // namespace graph_utils } // namespace arm_compute -#endif /* __ARM_COMPUTE_GRAPH_UTILS_H__ */ +#endif /* __ARM_COMPUTE_UTILS_GRAPH_UTILS_H__ */ diff --git a/utils/TypePrinter.h b/utils/TypePrinter.h index 7c23399bc1..70196882de 100644 --- a/utils/TypePrinter.h +++ b/utils/TypePrinter.h @@ -978,7 +978,6 @@ inline std::string to_string(const TensorInfo &info) return str.str(); } -//FIXME: Check why this doesn't work and the TensorShape and Coordinates overload are needed /** Formatted output of the Dimensions type. * * @param[in] dimensions Type to output. diff --git a/utils/command_line/CommandLineParser.h b/utils/command_line/CommandLineParser.h index 06c4bf5e2f..f834af8e9f 100644 --- a/utils/command_line/CommandLineParser.h +++ b/utils/command_line/CommandLineParser.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2018 ARM Limited. + * Copyright (c) 2017-2019 ARM Limited. * * SPDX-License-Identifier: MIT * @@ -225,7 +225,7 @@ inline void CommandLineParser::print_help(const std::string &program_name) const for(const auto &option : _positional_options) { - //FIXME: Print help string as well + // TODO(COMPMID-2079): Print help string as well std::cout << option->name() << "\n"; } } |