diff options
| author | Anthony Barbier <anthony.barbier@arm.com> | 2018-08-10 14:10:08 +0100 |
|---|---|---|
| committer | Anthony Barbier <anthony.barbier@arm.com> | 2018-11-02 16:54:54 +0000 |
| commit | 5a65cfd30e571bc5c24e2333e256f2a4b630f8cb (patch) | |
| tree | 4c8d09361d5edc6bc0313110491a0a5353c44e09 /scripts | |
| parent | 8914e32962be3dc8608499e3c0f2f13141493fc4 (diff) | |
| download | ComputeLibrary-5a65cfd30e571bc5c24e2333e256f2a4b630f8cb.tar.gz | |
COMPMID-1478: Fixed Doxygen comments + minor fixes
- Allow check_bad_style.sh to only run on some of the files
- Pass missing lws_hint() in CLNormalizationLayerKernel
Change-Id: I2cf44f82f7ba6c8dc8d40691aeec7c6c3de385b5
Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/143628
Reviewed-by: Michele DiGiorgio <michele.digiorgio@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Tested-by: Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/check_bad_style.sh | 27 |
1 files changed, 18 insertions, 9 deletions
diff --git a/scripts/check_bad_style.sh b/scripts/check_bad_style.sh index 292cf518cd..b3e0b39be5 100755 --- a/scripts/check_bad_style.sh +++ b/scripts/check_bad_style.sh @@ -2,9 +2,18 @@ set -e -DIRECTORIES="./arm_compute ./src ./examples ./tests ./utils ./support" +ALL_DIRECTORIES="./arm_compute ./src ./examples ./tests ./utils ./support" -grep -HrnP --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "/\*\*$" $DIRECTORIES | tee bad_style.log +#If no arguments were passed: default to check all the folders: +if [ ! -n "$1" ] +then + FILES=$ALL_DIRECTORIES +else + #else only check the files that were passed on the command line: + FILES=$@ +fi + +grep -HrnP --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "/\*\*$" $FILES | tee bad_style.log if (( `cat bad_style.log | wc -l` > 0 )) then echo "" @@ -12,7 +21,7 @@ then exit -1 fi -grep -Hnr --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm --exclude=Doxyfile "@brief" $DIRECTORIES | tee bad_style.log +grep -Hnr --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm --exclude=Doxyfile "@brief" $FILES | tee bad_style.log if (( `cat bad_style.log | wc -l` > 0 )) then echo "" @@ -20,7 +29,7 @@ then exit -1 fi -grep -HnRE --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "\buint " --exclude-dir=cl_kernels --exclude-dir=cs_shaders $DIRECTORIES | tee bad_style.log +grep -HnRE --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "\buint " --exclude-dir=cl_kernels --exclude-dir=cs_shaders $FILES | tee bad_style.log if [[ $(cat bad_style.log | wc -l) > 0 ]] then echo "" @@ -28,7 +37,7 @@ then exit -1 fi -grep -HnR --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "float32_t" $DIRECTORIES | tee bad_style.log +grep -HnR --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "float32_t" $FILES | tee bad_style.log if [[ $(cat bad_style.log | wc -l) > 0 ]] then echo "" @@ -36,7 +45,7 @@ then exit -1 fi -grep -Hnir --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "arm[_ ]\?cv" $DIRECTORIES | tee bad_style.log +grep -Hnir --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "arm[_ ]\?cv" $FILES | tee bad_style.log if [[ $(cat bad_style.log | wc -l) > 0 ]] then echo "" @@ -44,7 +53,7 @@ then exit -1 fi -grep -Hnir --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "#.*if.*defined[^(]" $DIRECTORIES | tee bad_style.log +grep -Hnir --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "#.*if.*defined[^(]" $FILES | tee bad_style.log if [[ $(cat bad_style.log | wc -l) > 0 ]] then echo "" @@ -52,7 +61,7 @@ then exit -1 fi -grep -Hnir --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "#else$\|#endif$" $DIRECTORIES | tee bad_style.log +grep -Hnir --exclude-dir=assembly --exclude-dir=convolution --exclude-dir=arm_gemm "#else$\|#endif$" $FILES | tee bad_style.log if [[ $(cat bad_style.log | wc -l) > 0 ]] then echo "" @@ -69,7 +78,7 @@ then fi spdx_missing=0 -for f in $(find $DIRECTORIES -type f) +for f in $(find $FILES -type f) do if [[ $(grep SPDX $f | wc -l) == 0 ]] then |