diff options
| author | SiCongLi <sicong.li@arm.com> | 2021-12-22 11:22:40 +0000 |
|---|---|---|
| committer | SiCong Li <sicong.li@arm.com> | 2021-12-25 10:54:51 +0000 |
| commit | c4270cf958e85e0c41590030e1f9e228493a5ba0 (patch) | |
| tree | fe26e2724df1d9da12c8462a576688b93838bc79 /arm_compute | |
| parent | cb86956e1972be4b2ddbaacaa23a0d21185f8ccb (diff) | |
| download | ComputeLibrary-c4270cf958e85e0c41590030e1f9e228493a5ba0.tar.gz | |
Add tests for FP Cpu Pooling where pool region is completely outside the input
* Add floating point validation tests for this configuration
* Fix reference implementation to return -inf for this configuration
* Prohibit this config in Cl, as well as non-float cases in Cpu
* Direct this config to non-asm path
Resolves COMPMID-4998
Change-Id: If88025c51b14ea337aea2441c548f858e95e5819
Signed-off-by: SiCongLi <sicong.li@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/6857
Reviewed-by: Gunes Bayir <gunes.bayir@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'arm_compute')
| -rw-r--r-- | arm_compute/core/Utils.h | 7 | ||||
| -rw-r--r-- | arm_compute/runtime/CL/functions/CLPoolingLayer.h | 3 | ||||
| -rw-r--r-- | arm_compute/runtime/NEON/functions/NEPoolingLayer.h | 2 |
3 files changed, 12 insertions, 0 deletions
diff --git a/arm_compute/core/Utils.h b/arm_compute/core/Utils.h index 0ad80bc998..88cb295c44 100644 --- a/arm_compute/core/Utils.h +++ b/arm_compute/core/Utils.h @@ -886,6 +886,13 @@ const std::string &string_from_norm_type(NormType type); * @return The string describing the pooling type. */ const std::string &string_from_pooling_type(PoolingType type); +/** Check if the pool region is entirely outside the input tensor + * + * @param[in] info @ref PoolingLayerInfo to be checked. + * + * @return True if the pool region is entirely outside the input tensor, False otherwise. + */ +bool is_pool_region_entirely_outside_input(const PoolingLayerInfo &info); /** Translates a given GEMMLowp output stage to a string. * * @param[in] output_stage @ref GEMMLowpOutputStageInfo to be translated to string. diff --git a/arm_compute/runtime/CL/functions/CLPoolingLayer.h b/arm_compute/runtime/CL/functions/CLPoolingLayer.h index 1975e15470..2163c16801 100644 --- a/arm_compute/runtime/CL/functions/CLPoolingLayer.h +++ b/arm_compute/runtime/CL/functions/CLPoolingLayer.h @@ -66,6 +66,9 @@ public: * |F16 |F16 | * |F32 |F32 | * + * @note Source tensor is padded with -inf for MAX pooling and 0 otherwise + * Cases where pooling region is completely outside input tensor are not supported + * * @param[in,out] input Source tensor. (Written to only when padding != 0) Data types supported: QASYMM8/QASYMM8_SIGNED/F16/F32. * @param[out] output Destination tensor. Data types supported: Same as @p input. * @param[in] pool_info Contains pooling operation information described in @ref PoolingLayerInfo. diff --git a/arm_compute/runtime/NEON/functions/NEPoolingLayer.h b/arm_compute/runtime/NEON/functions/NEPoolingLayer.h index 9398e1fce9..9147ad9687 100644 --- a/arm_compute/runtime/NEON/functions/NEPoolingLayer.h +++ b/arm_compute/runtime/NEON/functions/NEPoolingLayer.h @@ -71,6 +71,8 @@ public: * |F32 |F32 | * * @note F16 is supported for pool sizes 2 and 3 only + * @note Source tensor is padded with -inf for MAX pooling and 0 otherwise + * Cases where pooling region is completely outside input tensor are only supported for floating point data type * * @param[in, out] input Source tensor. (Written to only when padding != 0) Data types supported: QASYMM8/QASYMM8_SIGNED/F16/F32. * @param[out] output Destination tensor. Data types supported: Same as @p input. |