diff options
| author | Matthew Bentham <Matthew.Bentham@arm.com> | 2023-07-19 15:01:00 +0000 |
|---|---|---|
| committer | Matthew Bentham <matthew.bentham@arm.com> | 2023-07-25 14:52:40 +0000 |
| commit | 0a59e69fd922b02d9e3b5b043ee7f891061df7be (patch) | |
| tree | f8da537735e9a2bf00f8dc495a35e94c08776fd1 /SConstruct | |
| parent | 0250fa6c2a0bdbf88c1264f32ad0a1a4e3fec3f3 (diff) | |
| download | ComputeLibrary-0a59e69fd922b02d9e3b5b043ee7f891061df7be.tar.gz | |
Fix problem with exception handling in CPPScheduler
If an exception was thrown in the main thread, the child threads
were not being synchronised, leading to undefined behaviour (and
probably the program crashing instead of correctly propagating the
exception).
Add support to the build system for enabling ThreadSanitizer.
This needs a build system option rather than simply passing
extra_cxx/link_flags because the sanitizer options are
incompatible with -Wl,-undefined,error.
Add a unit test for throwing an exception within a CPPScheduler
workload.
Signed-off-by: Matthew Bentham <Matthew.Bentham@arm.com>
Change-Id: I7638272a5d43a24a861f3e6d63f3ee7b099483b5
Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/c/VisualCompute/ComputeLibrary/+/538048
Comments-Addressed: bsgcomp <bsgcomp@arm.com>
Tested-by: bsgcomp <bsgcomp@arm.com>
Reviewed-by: Viet-Hoa Do <viet-hoa.do@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/9957
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Benchmark: Arm Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'SConstruct')
| -rw-r--r-- | SConstruct | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/SConstruct b/SConstruct index 4480c710d3..68c518a4a0 100644 --- a/SConstruct +++ b/SConstruct @@ -133,6 +133,7 @@ vars.AddVariables( ListVariable("data_layout_support", "Enable a list of data layout to support", "all", ["nhwc", "nchw"]), ("toolchain_prefix", "Override the toolchain prefix; used by all toolchain components: compilers, linker, assembler etc. If unspecified, use default(auto) prefixes; if passed an empty string '' prefixes would be disabled", "auto"), ("compiler_prefix", "Override the compiler prefix; used by just compilers (CC,CXX); further overrides toolchain_prefix for compilers; this is for when the compiler prefixes are different from that of the linkers, archivers etc. If unspecified, this is the same as toolchain_prefix; if passed an empty string '' prefixes would be disabled", "auto"), + BoolVariable("thread_sanitizer", "Enable ThreadSanitizer", False), ("extra_cxx_flags", "Extra CXX flags to be appended to the build command", ""), ("extra_link_flags", "Extra LD flags to be appended to the build command", ""), ("compiler_cache", "Command to prefix to the C and C++ compiler (e.g ccache)", ""), @@ -613,6 +614,10 @@ if env['asserts']: if env['logging']: env.Append(CPPDEFINES = ['ARM_COMPUTE_LOGGING_ENABLED']) +if env['thread_sanitizer']: + env.Append(CXXFLAGS = ['-fsanitize=thread']) + env.Append(LINKFLAGS = ['-fsanitize=thread']) + env.Append(CPPPATH = ['#/include', "#"]) env.Append(CXXFLAGS = env['extra_cxx_flags']) env.Append(LINKFLAGS = env['extra_link_flags']) |