Fix MAXIMUM/MINIMUM handling of NaNs and zeroes

Change FP_SPECIAL testing to be used for DOT_PRODUCT cases only.
Use default EXACT matching - where zeroes of different signs will
be ignored when testing for equality

Signed-off-by: Jeremy Johnson <jeremy.johnson@arm.com>
Change-Id: I0461c42258611cae597f693507075b3ef15fbe19

1 files changed, 31 insertions, 0 deletions

diff --git a/reference_model/src/ops/ewise_binary.cc b/reference_model/src/ops/ewise_binary.cc
index 8cc1319..d4a9f2f 100644
--- a/reference_model/src/ops/ewise_binary.cc
+++ b/reference_model/src/ops/ewise_binary.cc
@@ -411,6 +411,22 @@ int OpMaximum<Rank, Dtype>::register_fcn()
         case TOSA_REF_TYPE_BF16:
         case TOSA_REF_TYPE_FP32:
         case TOSA_REF_TYPE_FP64:
+            this->fcn = [](InEigenType a, InEigenType b) -> OutEigenType {
+                if (isnan(a))
+                {
+                    return a;
+                }
+                else if (isnan(b))
+                {
+                    return b;
+                }
+                else
+                {
+                    return a > b ? a : b;
+                }
+            };
+            break;
+
         case TOSA_REF_TYPE_INT32:
             this->fcn = [](InEigenType a, InEigenType b) -> OutEigenType { return a > b ? a : b; };
             break;
@@ -430,6 +446,21 @@ int OpMinimum<Rank, Dtype>::register_fcn()
         case TOSA_REF_TYPE_BF16:
         case TOSA_REF_TYPE_FP32:
         case TOSA_REF_TYPE_FP64:
+            this->fcn = [](InEigenType a, InEigenType b) -> OutEigenType {
+                if (isnan(a))
+                {
+                    return a;
+                }
+                else if (isnan(b))
+                {
+                    return b;
+                }
+                else
+                {
+                    return a < b ? a : b;
+                }
+            };
+            break;
         case TOSA_REF_TYPE_INT32:
             this->fcn = [](InEigenType a, InEigenType b) -> OutEigenType { return a < b ? a : b; };
             break;