aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGiorgio Arena <giorgio.arena@arm.com>2021-04-13 09:52:18 +0100
committerGeorgios Pinitas <georgios.pinitas@arm.com>2021-04-15 17:43:31 +0000
commitebbb6f9e2735f903a4cb75c23ab7c80797079c25 (patch)
treeef6bdfc12189dae27908b7b3042782f190c848c4
parent5d75d4a236bd4d73b514bd81d902fbdbd660b00a (diff)
downloadComputeLibrary-ebbb6f9e2735f903a4cb75c23ab7c80797079c25.tar.gz
Add Implicit Padding in DirectConvolution Fixture
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com> Change-Id: I97ef222ce9ea5a9c01089697f67863673985dff8 Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5410 Tested-by: Arm Jenkins <bsgcomp@arm.com> Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com> Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
-rw-r--r--tests/validation/Helpers.h3
-rw-r--r--tests/validation/fixtures/DirectConvolutionLayerFixture.h3
2 files changed, 3 insertions, 3 deletions
diff --git a/tests/validation/Helpers.h b/tests/validation/Helpers.h
index 3ba3bd1259..e06d239307 100644
--- a/tests/validation/Helpers.h
+++ b/tests/validation/Helpers.h
@@ -230,7 +230,8 @@ std::pair<int, int> get_quantized_qasymm8_signed_bounds(const QuantizationInfo &
*/
std::pair<int, int> get_symm_quantized_per_channel_bounds(const QuantizationInfo &quant_info, float min, float max, size_t channel_id = 0);
-/** Add random padding along the X axis (between 1 and 16 columns per side) to all the input tensors
+/** Add random padding along the X axis (between 1 and 16 columns per side) to all the input tensors.
+ * This is used in our validation suite in order to simulate implicit padding addition after configuring, but before allocating.
*
* @param[in] tensors List of tensors to add padding to
* @param[in] data_layout (Optional) Data layout of the operator
diff --git a/tests/validation/fixtures/DirectConvolutionLayerFixture.h b/tests/validation/fixtures/DirectConvolutionLayerFixture.h
index b79991e3d4..7f1896678e 100644
--- a/tests/validation/fixtures/DirectConvolutionLayerFixture.h
+++ b/tests/validation/fixtures/DirectConvolutionLayerFixture.h
@@ -171,8 +171,7 @@ protected:
ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS);
ARM_COMPUTE_EXPECT(dst.info()->is_resizable(), framework::LogLevel::ERRORS);
- // TODO: uncomment after COMPMID-4341
- // add_padding_x({ &src, &weights, &bias, &dst }, data_layout);
+ add_padding_x({ &src, &weights, &bias, &dst }, data_layout);
// Allocate tensors
src.allocator()->allocate();