From ebbb6f9e2735f903a4cb75c23ab7c80797079c25 Mon Sep 17 00:00:00 2001 From: Giorgio Arena Date: Tue, 13 Apr 2021 09:52:18 +0100 Subject: Add Implicit Padding in DirectConvolution Fixture Signed-off-by: Giorgio Arena Change-Id: I97ef222ce9ea5a9c01089697f67863673985dff8 Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5410 Tested-by: Arm Jenkins Reviewed-by: Michele Di Giorgio Comments-Addressed: Arm Jenkins --- tests/validation/Helpers.h | 3 ++- tests/validation/fixtures/DirectConvolutionLayerFixture.h | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/validation/Helpers.h b/tests/validation/Helpers.h index 3ba3bd1259..e06d239307 100644 --- a/tests/validation/Helpers.h +++ b/tests/validation/Helpers.h @@ -230,7 +230,8 @@ std::pair get_quantized_qasymm8_signed_bounds(const QuantizationInfo & */ std::pair get_symm_quantized_per_channel_bounds(const QuantizationInfo &quant_info, float min, float max, size_t channel_id = 0); -/** Add random padding along the X axis (between 1 and 16 columns per side) to all the input tensors +/** Add random padding along the X axis (between 1 and 16 columns per side) to all the input tensors. + * This is used in our validation suite in order to simulate implicit padding addition after configuring, but before allocating. * * @param[in] tensors List of tensors to add padding to * @param[in] data_layout (Optional) Data layout of the operator diff --git a/tests/validation/fixtures/DirectConvolutionLayerFixture.h b/tests/validation/fixtures/DirectConvolutionLayerFixture.h index b79991e3d4..7f1896678e 100644 --- a/tests/validation/fixtures/DirectConvolutionLayerFixture.h +++ b/tests/validation/fixtures/DirectConvolutionLayerFixture.h @@ -171,8 +171,7 @@ protected: ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(dst.info()->is_resizable(), framework::LogLevel::ERRORS); - // TODO: uncomment after COMPMID-4341 - // add_padding_x({ &src, &weights, &bias, &dst }, data_layout); + add_padding_x({ &src, &weights, &bias, &dst }, data_layout); // Allocate tensors src.allocator()->allocate(); -- cgit v1.2.1