diff options
| author | Mikael Olsson <mikael.olsson@arm.com> | 2023-08-03 12:41:01 +0200 |
|---|---|---|
| committer | Mikael Olsson <mikael.olsson@arm.com> | 2023-08-09 15:09:38 +0200 |
| commit | fab31ebedaa0d2a3026ccb2de453d33780aed7c6 (patch) | |
| tree | 1a20d2e1168ceaf369ce7c37e96a347befaa1570 | |
| parent | 529cfad55fa3b52ed8c78ad486812e7bcf56add6 (diff) | |
| download | ethos-u-linux-driver-stack-fab31ebedaa0d2a3026ccb2de453d33780aed7c6.tar.gz | |
Remove protocol version request IOCTL from UAPI
The current implementation of the protocol version request IOCTL call
doesn't return any version information and the protocol version is not
needed by any userspace program as it's for the communication between
the Linux kernel NPU driver and firmware. The IOCTL call has therefore
been removed from the UAPI and the inference runner has been updated
accordingly.
Change-Id: I9ed09e55d9522996a182f237c8a6db2f45bc40a9
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com>
| -rw-r--r-- | kernel/ethosu_device.c | 4 | ||||
| -rw-r--r-- | kernel/uapi/ethosu.h | 1 | ||||
| -rw-r--r-- | utils/inference_runner/inference_runner.cpp | 5 |
3 files changed, 1 insertions, 9 deletions
diff --git a/kernel/ethosu_device.c b/kernel/ethosu_device.c index ae257c3..32d04ae 100644 --- a/kernel/ethosu_device.c +++ b/kernel/ethosu_device.c @@ -259,10 +259,6 @@ static long ethosu_ioctl(struct file *file, file, cmd, arg); switch (cmd) { - case ETHOSU_IOCTL_VERSION_REQ: - dev_info(dev, "Device ioctl: Send version request"); - ret = ethosu_mailbox_version_request(&edev->mailbox); - break; case ETHOSU_IOCTL_CAPABILITIES_REQ: { dev_info(dev, "Device ioctl: Capabilities request"); diff --git a/kernel/uapi/ethosu.h b/kernel/uapi/ethosu.h index d95bf05..2451623 100644 --- a/kernel/uapi/ethosu.h +++ b/kernel/uapi/ethosu.h @@ -43,7 +43,6 @@ namespace EthosU { #define ETHOSU_IOWR(nr, type) _IOWR(ETHOSU_IOCTL_BASE, nr, type) #define ETHOSU_IOCTL_PING ETHOSU_IO(0x00) -#define ETHOSU_IOCTL_VERSION_REQ ETHOSU_IO(0x01) #define ETHOSU_IOCTL_CAPABILITIES_REQ ETHOSU_IOR(0x02, \ struct ethosu_uapi_device_capabilities) #define ETHOSU_IOCTL_BUFFER_CREATE ETHOSU_IOR(0x10, \ diff --git a/utils/inference_runner/inference_runner.cpp b/utils/inference_runner/inference_runner.cpp index 9df67ed..42b89fc 100644 --- a/utils/inference_runner/inference_runner.cpp +++ b/utils/inference_runner/inference_runner.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020-2022 Arm Limited. All rights reserved. + * Copyright (c) 2020-2023 Arm Limited. All rights reserved. * * SPDX-License-Identifier: Apache-2.0 * @@ -215,9 +215,6 @@ int main(int argc, char *argv[]) { cout << "Send Ping" << endl; device.ioctl(ETHOSU_IOCTL_PING); - cout << "Send version request" << endl; - device.ioctl(ETHOSU_IOCTL_VERSION_REQ); - cout << "Send capabilities request" << endl; Capabilities capabilities = device.capabilities(); |