diff options
| author | Sang-Hoon Park <sang-hoon.park@arm.com> | 2020-11-18 13:52:11 +0000 |
|---|---|---|
| committer | Sang-Hoon Park <sang-hoon.park@arm.com> | 2020-11-27 10:17:13 +0000 |
| commit | 2dbc586417d5a36fcc0aca97267388466f7fff6e (patch) | |
| tree | 4b480123678ee9767d4ab618e91ef032d7c669b0 /tests | |
| parent | c90fcfe90721ecc4cf1045b60bf1c933cb4823f6 (diff) | |
| download | ComputeLibrary-2dbc586417d5a36fcc0aca97267388466f7fff6e.tar.gz | |
COMPMID-3961: Cleaning up logical operators on OpenCL
Change-Id: I04cd23e9abcb1828e54cd59fee3bfa95a6dea3fb
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4461
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: Manuel Bottini <manuel.bottini@arm.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/validation/fixtures/LogicalFixture.h | 8 | ||||
| -rw-r--r-- | tests/validation/reference/Logical.cpp | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/tests/validation/fixtures/LogicalFixture.h b/tests/validation/fixtures/LogicalFixture.h index 4bedb378bb..9f64d89d10 100644 --- a/tests/validation/fixtures/LogicalFixture.h +++ b/tests/validation/fixtures/LogicalFixture.h @@ -46,10 +46,10 @@ protected: template <typename U> void fill(U &&tensor, int i) { - constexpr auto zero = (uint8_t)0; - constexpr auto one = (uint8_t)0x1; - constexpr auto mixed = (uint8_t)0xAA; - constexpr auto mixed_bitwise_not = (uint8_t) ~(0xAA); + constexpr auto zero = static_cast<uint8_t>(0); + constexpr auto one = static_cast<uint8_t>(0x1); + constexpr auto mixed = static_cast<uint8_t>(0xAA); + constexpr auto mixed_bitwise_not = static_cast<uint8_t>((~0xAA)); library->fill_static_values(tensor, i == 0 ? std::vector<uint8_t> { zero, one, zero, one, mixed, zero, mixed } : diff --git a/tests/validation/reference/Logical.cpp b/tests/validation/reference/Logical.cpp index 9989ec841e..099abf6f96 100644 --- a/tests/validation/reference/Logical.cpp +++ b/tests/validation/reference/Logical.cpp @@ -44,9 +44,9 @@ T logical_binary_op(arm_compute::kernels::LogicalOperation op, T src1, T src2) return src1 || src2; // The following operators are either invalid or not binary operator case arm_compute::kernels::LogicalOperation::Not: - /* fall through */ + // fall through case arm_compute::kernels::LogicalOperation::Unknown: - /* fall through */ + // fall through default: ARM_COMPUTE_ASSERT(true); } |