diff options
| author | Sang-Hoon Park <sang-hoon.park@arm.com> | 2020-08-10 22:50:17 +0100 |
|---|---|---|
| committer | Sang-Hoon Park <sang-hoon.park@arm.com> | 2020-08-11 12:55:59 +0000 |
| commit | 77d3d2445fa590dee505c4171daef9dd6c8124ca (patch) | |
| tree | e799cd4005d569feba5e4bb5f9f44f5dd9e99bd2 /tests | |
| parent | 03d8a8991c6d87f227ed149ca653e897ed47dfc0 (diff) | |
| download | ComputeLibrary-77d3d2445fa590dee505c4171daef9dd6c8124ca.tar.gz | |
COMPMID-3607: Fix softmax summation logic for QASYMM8_SIGNED
For the elements that shouldn't contribute to the sum, zero
is used to compute the correct sum.
Change-Id: I5360534b5b0f81ee3d3aaaf5a046b99ecd943894
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3703
Reviewed-by: Pablo Marquez <pablo.tello@arm.com>
Reviewed-by: TeresaARM <teresa.charlinreyes@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/validation/CL/SoftmaxLayer.cpp | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/tests/validation/CL/SoftmaxLayer.cpp b/tests/validation/CL/SoftmaxLayer.cpp index ce05edc6d4..90c3058c5d 100644 --- a/tests/validation/CL/SoftmaxLayer.cpp +++ b/tests/validation/CL/SoftmaxLayer.cpp @@ -51,14 +51,6 @@ RelativeTolerance<float> tolerance_f32(0.001f); constexpr AbsoluteTolerance<uint8_t> tolerance_qasymm8(1); constexpr AbsoluteTolerance<int8_t> tolerance_qasymm8_signed(1); -/* - The following tolerance number is used as a workaround for the mismatches - caused by float computation in reference (and NEON) kernel - and integer computations in OpenCL kernel. - COMPMID-2958 is created to investigate this. -*/ -constexpr float tolerance_number_qasymm8_signed = 0.05f; - /** CNN data types */ const auto CNNDataTypes = framework::dataset::make("DataType", { @@ -276,7 +268,7 @@ FIXTURE_DATA_TEST_CASE(RunSmall, CLSoftmaxLayerQuantizedFixture<int8_t>, framewo framework::dataset::make("Axis", { 0 }))) { // Validate output - validate(CLAccessor(_target), _reference, tolerance_qasymm8_signed, tolerance_number_qasymm8_signed); + validate(CLAccessor(_target), _reference, tolerance_qasymm8_signed); } TEST_SUITE_END() // QASYMM8_SIGNED |