diff options
| author | Georgios Pinitas <georgios.pinitas@arm.com> | 2017-09-14 17:21:51 +0100 |
|---|---|---|
| committer | Anthony Barbier <anthony.barbier@arm.com> | 2018-11-02 16:35:24 +0000 |
| commit | ce54b56e0d91a8e73f3ecfede6a2b2aa323aa1fd (patch) | |
| tree | c83e7a849a38f11f2943f4cdfbb50bdc3bd3a58c /tests/validation/NEON/ConvolutionLayer.cpp | |
| parent | f8349fed4e64d081fd45e4a50c86c9d0f2ddac21 (diff) | |
| download | ComputeLibrary-ce54b56e0d91a8e73f3ecfede6a2b2aa323aa1fd.tar.gz | |
COMPMID-532: NEON ConvolutionLayer Quantised valgrind errors
When matrix B was one dimensional the AccessWindowTranpose did not add
bottom padding leading to invalid accesses.
Switches the matrix B access window to AccessWindowStatic and allows
AccessWindowStatic to add padding to 1D tensors.
Change-Id: Ic7fbd20e0c85575b98a506c4c22d2f9ecd8995a9
Reviewed-on: http://mpd-gerrit.cambridge.arm.com/87757
Reviewed-by: Moritz Pflanzer <moritz.pflanzer@arm.com>
Tested-by: Kaizen <jeremy.johnson+kaizengerrit@arm.com>
Diffstat (limited to 'tests/validation/NEON/ConvolutionLayer.cpp')
| -rw-r--r-- | tests/validation/NEON/ConvolutionLayer.cpp | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/tests/validation/NEON/ConvolutionLayer.cpp b/tests/validation/NEON/ConvolutionLayer.cpp index 584f34e11e..5880a7eda2 100644 --- a/tests/validation/NEON/ConvolutionLayer.cpp +++ b/tests/validation/NEON/ConvolutionLayer.cpp @@ -148,20 +148,18 @@ using NEConvolutionLayerFixedPointFixture = ConvolutionValidationFixedPointFixtu TEST_SUITE(Quantized) TEST_SUITE(QS8) // We test for fixed point precision [4,6] -//FIXME: COMPMID-532 -DISABLED_FIXTURE_DATA_TEST_CASE(RunSmall, NEConvolutionLayerFixedPointFixture<int8_t>, framework::DatasetMode::PRECOMMIT, combine(combine(combine(datasets::SmallConvolutionLayerDataset(), - framework::dataset::make("ReshapeWeights", { true, false })), - framework::dataset::make("DataType", DataType::QS8)), - framework::dataset::make("FractionalBits", 4, 7))) +FIXTURE_DATA_TEST_CASE(RunSmall, NEConvolutionLayerFixedPointFixture<int8_t>, framework::DatasetMode::PRECOMMIT, combine(combine(combine(datasets::SmallConvolutionLayerDataset(), + framework::dataset::make("ReshapeWeights", { true, false })), + framework::dataset::make("DataType", DataType::QS8)), + framework::dataset::make("FractionalBits", 4, 7))) { // Validate output validate(Accessor(_target), _reference, tolerance_q); } -//FIXME: COMPMID-532 -DISABLED_FIXTURE_DATA_TEST_CASE(RunLarge, NEConvolutionLayerFixedPointFixture<int8_t>, framework::DatasetMode::NIGHTLY, combine(combine(combine(datasets::LargeConvolutionLayerDataset(), - framework::dataset::make("ReshapeWeights", { true, false })), - framework::dataset::make("DataType", DataType::QS8)), - framework::dataset::make("FractionalBits", 4, 7))) +FIXTURE_DATA_TEST_CASE(RunLarge, NEConvolutionLayerFixedPointFixture<int8_t>, framework::DatasetMode::NIGHTLY, combine(combine(combine(datasets::LargeConvolutionLayerDataset(), + framework::dataset::make("ReshapeWeights", { true, false })), + framework::dataset::make("DataType", DataType::QS8)), + framework::dataset::make("FractionalBits", 4, 7))) { // Validate output validate(Accessor(_target), _reference, tolerance_q); |