diff options
| author | Sang-Hoon Park <sang-hoon.park@arm.com> | 2019-11-11 17:33:28 +0000 |
|---|---|---|
| committer | Sang-Hoon Park <sang-hoon.park@arm.com> | 2019-11-12 11:23:42 +0000 |
| commit | eaa01ab593428bc7267ebbe107b2d813a11b64b5 (patch) | |
| tree | 80e0af6b7ed0a82387080d6abb6c0a04d9f1d509 /arm_compute | |
| parent | 75041a1cb81c59a5a5ddd9b708476c0142362d9e (diff) | |
| download | ComputeLibrary-eaa01ab593428bc7267ebbe107b2d813a11b64b5.tar.gz | |
COMPMID-2671 use Signed32 for default output data type of ArgMinMax
Signed32 is used as data types before and after reshaping of ArgMinMax.
Change-Id: I230af43a931d4e106de6c72f716ced1dab511084
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/2262
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Giorgio Arena <giorgio.arena@arm.com>
Diffstat (limited to 'arm_compute')
4 files changed, 16 insertions, 14 deletions
diff --git a/arm_compute/core/CL/kernels/CLReductionOperationKernel.h b/arm_compute/core/CL/kernels/CLReductionOperationKernel.h index 18a1bab2dc..172ed8985a 100644 --- a/arm_compute/core/CL/kernels/CLReductionOperationKernel.h +++ b/arm_compute/core/CL/kernels/CLReductionOperationKernel.h @@ -33,10 +33,10 @@ class ICLTensor; /** Interface for the reduction operation kernel * - * @note For ARG_MIN/ARG_MAX reduction, the indices are computed in unsigned - * 32-bit (U32). It is the user's responsibility to check that the - * results do not overflow in case the output data type is set to signed - * 32-bit integer (S32). + * @note For ARG_MIN/ARG_MAX reduction, the default data type for an uninitialized + * output tensor is signed 32-bit integer (S32). It is the user's responsibility + * to check that the results do not overflow because the indices are computed + * in unsigned 32-bit (U32). */ class CLReductionOperationKernel : public ICLKernel { diff --git a/arm_compute/core/NEON/kernels/NEReductionOperationKernel.h b/arm_compute/core/NEON/kernels/NEReductionOperationKernel.h index 4b28b8dbcd..0d402fb044 100644 --- a/arm_compute/core/NEON/kernels/NEReductionOperationKernel.h +++ b/arm_compute/core/NEON/kernels/NEReductionOperationKernel.h @@ -32,10 +32,10 @@ class ITensor; /** NEON kernel to perform a reduction operation * - * @note For ARG_MIN/ARG_MAX reduction, the indices are computed in unsigned - * 32-bit (U32). It is the user's responsibility to check that the - * results do not overflow in case the output data type is set to signed - * 32-bit integer (S32). + * @note For ARG_MIN/ARG_MAX reduction, the default data type for an uninitialized + * output tensor is signed 32-bit integer (S32). It is the user's responsibility + * to check that the results do not overflow because the indices are computed + * in unsigned 32-bit (U32). */ class NEReductionOperationKernel : public INEKernel { diff --git a/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h b/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h index 28feee09ab..1b465a4866 100644 --- a/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h +++ b/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h @@ -38,9 +38,10 @@ class CLReductionOperation; /** Function to calculate the index of the minimum or maximum values in a * tensor based on an axis. * - * @note The indices are computed in unsigned 32-bit (U32). It is the user's - * responsibility to check that the results do not overflow in case the - * output data type is set to signed 32-bit integer (S32). + * @note The default data type for an uninitialized output tensor is + * signed 32-bit integer (S32). It is the user's responsibility to check + * that the results do not overflow because the indices are computed + * in unsigned 32-bit (U32). */ class CLArgMinMaxLayer : public IFunction { diff --git a/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h b/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h index d2ddff2665..ca6794bf82 100644 --- a/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h +++ b/arm_compute/runtime/NEON/functions/NEArgMinMaxLayer.h @@ -42,9 +42,10 @@ class ITensor; * -# @ref NEReductionOperationKernel * -# @ref NEFillBorderKernel * - * @note The indices are computed in unsigned 32-bit (U32). It is the user's - * responsibility to check that the results do not overflow in case the - * output data type is set to signed 32-bit integer (S32). + * @note The default data type for an uninitialized output tensor is + * signed 32-bit integer (S32). It is the user's responsibility to check + * that the results do not overflow because the indices are computed + * in unsigned 32-bit (U32). */ class NEArgMinMaxLayer : public IFunction { |