From 9151dd5b223ea069e4c9526e9e82442edaf525d0 Mon Sep 17 00:00:00 2001
From: Dominic Symes <dominic.symes@arm.com>
Date: Fri, 3 Nov 2023 14:29:51 +0000
Subject: REDUCE_SUM: Specify the accumulator type

For bf16_t data type, REDUCE_SUM is changed to use fp32_t
as the accumulator type to be consistent with CONV2D.
For other data types the accumulator type is the same
as in_out_t (and so no change).
Also correct the rank limit text.

Update reduction pseudo-code to be consistent with
REDUCE_SUM.

Change-Id: I9923066be7d1b7edb0efd9bcf3365b4af9501beb
Signed-off-by: Dominic Symes <dominic.symes@arm.com>
---
 tosa.xml | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

(limited to 'tosa.xml')

diff --git a/tosa.xml b/tosa.xml
index fa67c1c..e5a0872 100644
--- a/tosa.xml
+++ b/tosa.xml
@@ -1880,7 +1880,7 @@
         <name>REDUCE_SUM</name>
         <arguments>
           <argument category="input" name="input" type="tensor_t" shape="shape1" tensor-element-type="in_out_t">
-            <description>Input tensor with rank from 1 to 4</description>
+            <description>Input tensor</description>
             <rank min="1" max="MAX_RANK"/>
           </argument>
           <argument category="attribute" name="axis" type="tensor_t" shape="-" tensor-element-type="i32_t">
@@ -1894,17 +1894,18 @@
         </arguments>
         <types>
           <type name='in_out_t'/>
+          <type name='acc_t'/>
         </types>
-        <typesupport mode="signed 32" in_out_t="i32_t"/>
-        <typesupport mode="fp16" in_out_t="fp16_t">
+        <typesupport mode="signed 32" in_out_t="i32_t" acc_t="i32_t"/>
+        <typesupport mode="fp16" in_out_t="fp16_t" acc_t="fp16_t">
           <profile name="MI"/>
           <profile name="MT"/>
         </typesupport>
-        <typesupport mode="bf16" in_out_t="bf16_t">
+        <typesupport mode="bf16" in_out_t="bf16_t" acc_t="fp32_t">
           <profile name="MI"/>
           <profile name="MT"/>
         </typesupport>
-        <typesupport mode="fp32" in_out_t="fp32_t">
+        <typesupport mode="fp32" in_out_t="fp32_t" acc_t="fp32_t">
           <profile name="MI"/>
           <profile name="MT"/>
         </typesupport>
-- 
cgit v1.2.1