aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-17Update TOSA version to 0.30.0v0.30.0v0.30Eric Kunze
Also update copyright date for specification. Change-Id: I72d2423247f62fa304d0c0535ef33defb903b74e Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-06-17Revert RESIZE behvior to the 0.23 versionEric Kunze
The current version does not match the reference model or serialization library. Revert to the old behavior until the model is updated and tested that it works correctly. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I237dc3e94e6c31337073524527da75084ba7b578
2022-06-17Initial work on floating-point type definitionEric Kunze
Define operations in terms of common floating-point data types. Definitions for the data types are in the introduction. Added a section to describe status of the different profiles. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: Iac57026806acfb7913f40af61176322fb02b7cc1
2022-06-17Rework the introductionEric Kunze
The information on quantization and numerics was out of date. The tensor access helpers were also consolidated and moved into their own section in the pseudocode chapter. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I472e674ed88f4a3ef379010cf50b13cf8afa5f17
2022-06-13Fix typo on CONV3D pseudocodeEric Kunze
Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: Ib953cc4b635469034300662b9ae997d0a1bd58a7
2022-06-02Make the use of inverse in FFT2D definition consistentEric Kunze
The captions for the images used 'direction', instead of 'inverse' which is the attribute name. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I4d8ab9642288efb984d03b7862068e09334ce8f6
2022-06-01Add FFT operators to MI/MT profilesEric Kunze
Adds FFT2D for complex->complex FFT Adds RFFT2D for real->complex FFT Change-Id: Id50f96b8f66f17c3020767c002f0c1f41a76d62e Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-06-01RESIZE: Clarify offset and border rangesDominic Symes
Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: Ibb60c192ea60b665cec8d91f7de7cc6e3f553fa6
2022-05-26Update RESHAPE pseudocodeEric Kunze
Remove the calculation of a -1 dimension from the operator. Calculates the new coordinates, and adds the proper tensor_read/tensor_write for the data. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: Iad1d83c170732bdfb3652dead9044809168b23d2
2022-05-24Fix typo in TILE operatorEric Kunze
Replicates multiples times, not multiplies. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I78c19013d08295171a20fead17661a8f9ea68ac8
2022-05-16Add the uint16_t data typeEric Kunze
An unsigned 16-bit integer data type for use with image networks. Limited to only operating with the RESCALE operator for conversion to signed int16. Zero point can be 0 or 32768 in the RESCALE to allow for no loss of precision (by subtracting 32768), or keeping all values as positive, (zero point=0) with scaling/clipping as defined in the other RESCALE arguments. Change-Id: Id1aebab68fa207f8f8cc235fc3fa5d050307198e Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-05-10Mark RESCALE multiplier and scale as refsEric Kunze
They are arrays of multipliers and shifts to handle per channel scaling. Change-Id: I4451a87ef4d710fcb93745c8df73ec41752415c0 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-05-04Specify width of integer types for all operator argumentsKevin Petit
Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: I15ba640629433f87648ece24ffe723a60c8aaf11
2022-05-04RESIZE: Define scale as a ratio of integersDominic Symes
Define scaling factor as a ratio of integers so that output dimensions can be derived from input dimensions without rounding. Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: Ie4c1a323dec80379fb0d6db1767777e6c9760a11
2022-05-03Change from assignment to a check for output dims for tensor opsJeremy Johnson
Output dimensions should have been worked out correctly by the end of the compilation to TOSA Signed-off-by: Jeremy Johnson <jeremy.johnson@arm.com> Change-Id: I0193958d7d51bf1c6915a0953daa514f86516710
2022-05-03Specify width of integer typesDominic Symes
Clarify for types previously definded as int the width assumed by the specification. Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: Ied62d4803a4323a600d33cff09752a76ca48f18d
2022-04-29Fix round argument category for ARITHMETIC_RIGHT_SHIFTKevin Petit
It should be an attribute. Signed-off-by: Kevin Petit <kevin.petit@arm.com> Change-Id: I2c9c73605486a44297dad105dbdb94abfb5903fb
2022-04-20Simple fixes to the arguments to CAST and RESCALEKevin Petit
- The input/output types for CAST should be in_t* and out_t* - The shape for the multiplier and shift arguments to RESCALE was in the wrong column Change-Id: I0a3c4ffed15e36f0c4bf8fc9b4a84df5a17a5523 Signed-off-by: Kevin Petit <kevin.petit@arm.com>
2022-04-14Specify output dimension formulae for tensor opsDominic Symes
For each tensor op clarify how the output dimensions of output height (OH) and output width (OW) relate to the input height (IH) and input width (IW). Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: Iad36041f54e439c944cacf08afac5567dd2bad3f
2022-03-31Update makefile to fail build on spelling failureEric Kunze
Will also fail if aspell is not installed Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I4cab802b64a938797d84604af80cb37caa04f401
2022-03-16Update TRANSPOSE argument descriptionEric Kunze
Define the perms argument more clearly Change-Id: I9ea695ef38c2a8160ba0fc2020fa28150942e39e Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-03-15Update floating point edge casesEric Kunze
Cover cases where NaN, +/- 0, +/- infinity are involved Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I1a5a23c7b856ddb997f7cdc00282420294ef3e6d
2022-02-03TABLE: Clarify the interpolation slope rangeDominic Symes
The interpolation slope must not exceed int16_t range. Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: Ic9037dcc11c293c78b9398952118a129e3be66f5
2022-01-24apply_scale_32: adjust range checkingDominic Symes
Range checking adjusted to test that optimized implementations with prior left shift do not overflow. Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: I45a851a1dfc1f1a767f912bb1429d047ed0fb110
2022-01-10Simplify shape checking for TRANSPOSEEric Kunze
Have a simple outer check for proper size rather than checking during the inner loop. Change-Id: I20312c5f6b4aacbb630a2df0f901d8586caa04c0 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-01-07Fix range of C iteration in DEPTHWISE_CONV2DEric Kunze
The for_each already runs over 0 <= m < M, we don't need c to also iterate over M. Change-Id: Ia72b4be7e68e2f210e9bfc75e3958089d9930c47 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-01-07Ensure ranks match in apply_broadcastEric Kunze
ERROR_IF to make sure rank(index) == rank(out_shape) Also try to better explain what the expected value for index is. Change-Id: I0731324d33335cb1ffc0a6fbd153fbc8521ce2e9 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-01-07Add rudimentary spell check for specificationEric Kunze
We can't easily spell check the entire specification, the pseudocode and operator tables make it unworkable. This adds a simple python script that tries to extract just the description of the operators for checking. It also does a check over the entire license. A custom dictionary is used to contain specification custom words. Change-Id: I74558c03af1506e2970f20b3246d920c2753ca44 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2022-01-07Fix typo in TOSA licenseEric Kunze
PETMITTED -> PERMITTED NOTWITHSTANING -> NOTWITHSTANDING Change-Id: Ic1727fc0b87f74fa34af8582de11dabda3364b25 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2021-11-30RESIZE: Clarify output dimensionsDominic Symes
Clarify how RESIZE output dimensions are related to the input dimensions and add the border attributes to give a relation equation Change-Id: I081464de140634d1a99fd8538112c65af949385e Signed-off-by: Dominic Symes <dominic.symes@arm.com>
2021-11-24MUL: Correct code for the case of value2<0Dominic Symes
The previous call to apply_scale() was not valid for value2<0. Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: I3fbf38eaad964efdb0c4920da1a61aee67c9bba9
2021-11-12Use in_out_t when a type is used for input and outputEric Kunze
Also change acc_t to out_t when the value is being used as an output. This should make the argument tables easier to follow. Change-Id: I2a57f3c4eaf937f29da785ff5c11576663a39494
2021-11-12Insert missing close bracket in ADD pseudocodeEric Kunze
Change-Id: Ifec04d98b81b351efe110d5a07259f69df4f3014
2021-11-12Fix spelling mistake in SELECTEric Kunze
shpae3->shape3 Change-Id: I981edd50409cb5bac0fd8793a1bf578f20cc0574
2021-11-03Update specification revision to 0.24.0 draftEric Kunze
Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: Ib5da6027faf70d103bf0118d335b510d54a0b563
2021-10-29Remove draft tag from 0.23 specificationv0.23.0v0.23Eric Kunze
Change-Id: Id45f95bb06f314dff893a790cac4377d95f7c565 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2021-10-28Readability fixes for pseudocodeEric Kunze
Avoid use of acc for variables when they are not convolution accumulators. Use argument types appropriately. Add missing pseudocode for some MI operators Change-Id: I9113f9228dbcafb85206bcc39310e9599cb12c08
2021-10-28Clarify CLAMP pseudocodeEric Kunze
CLAMP does not do any zero point modification of its clamp limits. Callers to CLAMP should provide values with the zero-point accounted for in the arguments. Change-Id: I27ee468ecd5ab53e33dcbac9c91b705b39e49f96
2021-10-28Remove zp subtraction from tensor_read pseudocodeEric Kunze
Operators which use the zero-point functionalty for 8-bit integer processing are updated to do the zero-point subtract in their pseudocode. Note that the PAD operator no longer takes a zero point argument, and instead requires callers to account for the zero point in the pad_const argument. Change-Id: I3bca1cae85aa2093000c420f0433633c347a29de
2021-10-20Remove rank upper limit on TRANSPOSE operatorEric Kunze
Change-Id: I8935624362b3b8d1b125ccb801d039b97e88a2ef
2021-10-18Fix typo int_t to in_tEric Kunze
Change-Id: I495ed97896d8f560b9eb9ed7b05dd2ca1c564c73 Signed-off-by: Eric Kunze <eric.kunze@arm.com>
2021-10-15Add ERROR_IF checks to CONCAT operatorMatthew Haddon
* Add ERROR_IF checks to ensure that inputs have the correct rank, dimension lengths, and a suitable axis value * Make REVERSE REQUIRES check into an ERROR_IF * Some minor typo/formatting fixes Change-Id: Ie133788ca7e1deab194ba5ef97e47c39cdd170b6 Signed-off-by: Matthew Haddon <matthew.haddon@arm.com>
2021-10-12refactor SLICE error_if checksMatthew Haddon
* refactored error_if checks to avoid logic overlap * Added check to ensure that size dimensions match output dimension * Defined the rank() function in pseudocode helpers Change-Id: I56bf06252d9149d449c984126e8f2025a07d6034 Signed-off-by: Matthew Haddon <matthew.haddon@arm.com>
2021-10-08Force output shape to be correct for pooling operationsMatthew Haddon
The avg_pool2d and max_pool2d operators trigger an error_if statement if the output shape provided does not match the output shape generated by the operation given the input arguments. * Add pseudocode for floor operation * Fixed type in RESCALE op Signed-off-by: Matthew Haddon <matthew.haddon@arm.com> Change-Id: I087faa331c30becc05719cd1261f436019dcdeb5
2021-10-04Move quantization parameters into argument tablesEric Kunze
The TOSA specification doesn't have quantized types. Without those types, it is cleaner to move effects of quantization such as the zero points into the standard list of arguments, rather than existing as a separate table. Change-Id: I18ea2959e9d3e4a3e9a0ead7a8ca319bb4426a47
2021-09-29Allow PAD operator to pad with non-zeroEric Kunze
PAD now takes an additional attribute, with the padding value. Will generally be zero, but other values are allowed. tensor_read now requires the coordinates to be within the given tensor, with unpredictable behavior occurring if an access outside of the tensor occurs. Callers of tensor_read are expected to check the coordinates and take the appropriate action. The primary impact of this is to move the responsibility for padding to each operator. In practice, this is expected to not be a functional change, but a cleanup to make the behavior more clear. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I4f21ca9a13d82d422bbd66c400f23aa9a0bd2aa0
2021-09-27Change TABLE operator table to be an attribute for BI/MIEric Kunze
Use cases for BI/MI profiles show that the table argument for the TABLE operator will be known at compile time. Make it an attribute in that case. If a dynamic table is needed, the GATHER op is available. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: Icb54eaa443ed7896d5010c7a30af88b02c8a83ad
2021-09-24Don't allow pooling ops with excessive paddingEric Kunze
Padding larger than the kernel size leads to the odd effect where no values from the input tensor are used. This leads to a divide by 0 in AVG_POOL2D, as it only divides by the number of valid input values used, not padding. Change MAX_POOL2D to have the same limitation for consistency. Signed-off-by: Eric Kunze <eric.kunze@arm.com> Change-Id: I9cd0c0619f88f570d30c83053280460ae3d1cbfb
2021-09-24CAST: Correct profile for floating point castsDominic Symes
Signed-off-by: Dominic Symes <dominic.symes@arm.com> Change-Id: I91098ef7e18d18263f7b909f75b9df4460417725
2021-09-16Clarify range limitations for tensorsEric Kunze
Catch zero and negative sized tensors. Clarify configuration of bool_t in the reference model. int4_t limitations on -8 to stay symmetric around 0. Pad values must be >= 0. Stride,dilation values must be >= 1. Change-Id: Idb6ef740f855912a8340475ba319816f90c9b051 Signed-off-by: Eric Kunze <eric.kunze@arm.com>