From 2b5f217fb21e2d100baabd6161c8470b65669ed9 Mon Sep 17 00:00:00 2001 From: Benjamin Klimczak Date: Fri, 24 Nov 2023 12:23:16 +0000 Subject: MLIA-1037 Fix default backend validation Add a check to see if the default backends are installed when no backend is provided via CLI. Change-Id: I27dd9f35cfeec187f44cba06915d1be5a3a052b5 Signed-off-by: Benjamin Klimczak --- src/mlia/cli/command_validators.py | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/mlia/cli/command_validators.py b/src/mlia/cli/command_validators.py index a0f5433..04e04b1 100644 --- a/src/mlia/cli/command_validators.py +++ b/src/mlia/cli/command_validators.py @@ -7,6 +7,7 @@ import argparse import logging import sys +from mlia.backend.manager import get_available_backends from mlia.target.registry import default_backends from mlia.target.registry import get_target from mlia.target.registry import supported_backends @@ -14,9 +15,7 @@ from mlia.target.registry import supported_backends logger = logging.getLogger(__name__) -def validate_backend( - target_profile: str, backend: list[str] | None -) -> list[str] | None: +def validate_backend(target_profile: str, backend: list[str] | None) -> list[str]: """Validate backend with given target profile. This validator checks whether the given target-profile and backend are @@ -26,7 +25,15 @@ def validate_backend( target = get_target(target_profile) if not backend: - return default_backends(target) + defaults = default_backends(target) + missing_backends = set(defaults) + missing_backends.difference_update(get_available_backends()) + if missing_backends: + raise argparse.ArgumentError( + None, + f"The following default backends are not installed: {missing_backends}", + ) + return defaults compatible_backends = list(map(normalize_string, supported_backends(target))) backends = {normalize_string(b): b for b in backend} -- cgit v1.2.1