From 56b9264fcf26cc7cbd0a6d95ff2c32ba71f4626e Mon Sep 17 00:00:00 2001 From: Dhruv Chauhan Date: Wed, 3 May 2023 13:05:00 +0100 Subject: MLIA-755 Remove TOSA Extra Dependency - Removed TOSA Checker dependency from setup.cfg - Installation process calls directly the installation of TOSA Checker instead of the extra dependency Change-Id: I21e309b9316671959483bd2ef1ecaf644936a4cb --- setup.cfg | 4 ---- src/mlia/backend/tosa_checker/install.py | 4 ++-- tests/test_backend_tosa_checker_install.py | 4 ++-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/setup.cfg b/setup.cfg index bea8e42..404bef2 100644 --- a/setup.cfg +++ b/setup.cfg @@ -45,10 +45,6 @@ console_scripts = mlia=mlia.cli.main:main mlia-backend=mlia.cli.main:backend_main -[options.extras_require] -tosa = - tosa-checker==0.1.0 - [flake8] # ignored errors # E501 line too long diff --git a/src/mlia/backend/tosa_checker/install.py b/src/mlia/backend/tosa_checker/install.py index 72454bc..ba582ed 100644 --- a/src/mlia/backend/tosa_checker/install.py +++ b/src/mlia/backend/tosa_checker/install.py @@ -1,4 +1,4 @@ -# SPDX-FileCopyrightText: Copyright 2022, Arm Limited and/or its affiliates. +# SPDX-FileCopyrightText: Copyright 2022-2023, Arm Limited and/or its affiliates. # SPDX-License-Identifier: Apache-2.0 """Module for python package based installations.""" from __future__ import annotations @@ -13,7 +13,7 @@ def get_tosa_backend_installation() -> Installation: name="tosa-checker", description="Tool to check if a ML model is compatible " "with the TOSA specification", - packages_to_install=["mlia[tosa]"], + packages_to_install=["tosa-checker"], packages_to_uninstall=["tosa-checker"], expected_packages=["tosa-checker"], ) diff --git a/tests/test_backend_tosa_checker_install.py b/tests/test_backend_tosa_checker_install.py index 0393f0b..e0f5160 100644 --- a/tests/test_backend_tosa_checker_install.py +++ b/tests/test_backend_tosa_checker_install.py @@ -1,4 +1,4 @@ -# SPDX-FileCopyrightText: Copyright 2022, Arm Limited and/or its affiliates. +# SPDX-FileCopyrightText: Copyright 2022-2023, Arm Limited and/or its affiliates. # SPDX-License-Identifier: Apache-2.0 """Tests for python package based installations.""" from pathlib import Path @@ -44,7 +44,7 @@ def test_get_tosa_backend_installation( mock_package_manager.install.assert_not_called() tosa_installation.install(DownloadAndInstall()) - mock_package_manager.install.assert_called_once_with(["mlia[tosa]"]) + mock_package_manager.install.assert_called_once_with(["tosa-checker"]) tosa_installation.uninstall() mock_package_manager.uninstall.assert_called_once_with(["tosa-checker"]) -- cgit v1.2.1