From c350cdced0a8a2ca17376f58813e6d48d796ac7c Mon Sep 17 00:00:00 2001 From: alexander Date: Thu, 29 Apr 2021 20:36:09 +0100 Subject: MLECO-1868: Code static analyzer warnings fixes Signed-off-by: alexander Change-Id: Ie423e9cad3fabec6ab077ded7236813fe4933dea --- source/application/main/include/Classifier.hpp | 2 +- source/application/main/include/DataStructures.hpp | 4 +--- source/application/main/include/Mfcc.hpp | 24 +++++++++++----------- source/application/main/include/Profiler.hpp | 4 ++-- 4 files changed, 16 insertions(+), 18 deletions(-) (limited to 'source/application/main/include') diff --git a/source/application/main/include/Classifier.hpp b/source/application/main/include/Classifier.hpp index 510e6f9..3ee3148 100644 --- a/source/application/main/include/Classifier.hpp +++ b/source/application/main/include/Classifier.hpp @@ -62,7 +62,7 @@ namespace app { * @return true if successful, false otherwise. **/ template - bool _GetTopNResults(TfLiteTensor* tensor, + bool GetTopNResults(TfLiteTensor* tensor, std::vector& vecResults, uint32_t topNCount, const std::vector & labels); diff --git a/source/application/main/include/DataStructures.hpp b/source/application/main/include/DataStructures.hpp index 5cc8b5e..2f267c0 100644 --- a/source/application/main/include/DataStructures.hpp +++ b/source/application/main/include/DataStructures.hpp @@ -47,15 +47,13 @@ namespace app { * @param[in] rows Number of rows. * @param[in] cols Number of columns. */ - Array2d(unsigned rows, unsigned cols) + Array2d(unsigned rows, unsigned cols): _m_rows(rows), _m_cols(cols) { if (rows == 0 || cols == 0) { printf_err("Array2d constructor has 0 size.\n"); _m_data = nullptr; return; } - _m_rows = rows; - _m_cols = cols; _m_data = new T[rows * cols]; } diff --git a/source/application/main/include/Mfcc.hpp b/source/application/main/include/Mfcc.hpp index 6379fab..dcafe62 100644 --- a/source/application/main/include/Mfcc.hpp +++ b/source/application/main/include/Mfcc.hpp @@ -52,7 +52,7 @@ namespace audio { ~MfccParams() = default; /** @brief String representation of parameters */ - std::string Str(); + std::string Str() const; }; /** @@ -100,7 +100,7 @@ namespace audio { const float quantScale, const int quantOffset) { - this->_MfccComputePreFeature(audioData); + this->MfccComputePreFeature(audioData); float minVal = std::numeric_limits::min(); float maxVal = std::numeric_limits::max(); @@ -154,7 +154,7 @@ namespace audio { * bank weights and adding them up to be placed into * bins, according to the filter bank's first and last * indices (pre-computed for each filter bank element - * by _CreateMelFilterBank function). + * by CreateMelFilterBank function). * @param[in] fftVec Vector populated with FFT magnitudes. * @param[in] melFilterBank 2D Vector with filter bank weights. * @param[in] filterBankFilterFirst Vector containing the first indices of filter bank @@ -168,8 +168,8 @@ namespace audio { virtual bool ApplyMelFilterBank( std::vector& fftVec, std::vector>& melFilterBank, - std::vector& filterBankFilterFirst, - std::vector& filterBankFilterLast, + std::vector& filterBankFilterFirst, + std::vector& filterBankFilterLast, std::vector& melEnergies); /** @@ -214,37 +214,37 @@ namespace audio { std::vector _m_windowFunc; std::vector> _m_melFilterBank; std::vector _m_dctMatrix; - std::vector _m_filterBankFilterFirst; - std::vector _m_filterBankFilterLast; + std::vector _m_filterBankFilterFirst; + std::vector _m_filterBankFilterLast; bool _m_filterBankInitialised; arm::app::math::FftInstance _m_fftInstance; /** * @brief Initialises the filter banks and the DCT matrix. **/ - void _InitMelFilterBank(); + void InitMelFilterBank(); /** * @brief Signals whether the instance of MFCC has had its * required buffers initialised. * @return true if initialised, false otherwise. **/ - bool _IsMelFilterBankInited(); + bool IsMelFilterBankInited() const; /** * @brief Create mel filter banks for MFCC calculation. * @return 2D vector of floats. **/ - std::vector> _CreateMelFilterBank(); + std::vector> CreateMelFilterBank(); /** * @brief Computes and populates internal memeber buffers used * in MFCC feature calculation * @param[in] audioData 1D vector of 16-bit audio data. */ - void _MfccComputePreFeature(const std::vector& audioData); + void MfccComputePreFeature(const std::vector& audioData); /** @brief Computes the magnitude from an interleaved complex array. */ - void _ConvertToPowerSpectrum(); + void ConvertToPowerSpectrum(); }; diff --git a/source/application/main/include/Profiler.hpp b/source/application/main/include/Profiler.hpp index d93b257..c5f77e7 100644 --- a/source/application/main/include/Profiler.hpp +++ b/source/application/main/include/Profiler.hpp @@ -125,8 +125,8 @@ namespace app { * @param[in] name Name for the profiling unit series to be * appended to. **/ - void _AddProfilingUnit(time_counter start, time_counter end, - const std::string& name); + void AddProfilingUnit(time_counter start, time_counter end, + const std::string& name); }; } /* namespace app */ -- cgit v1.2.1