diff options
author | Björn Davidsson <bjoern.davidsson@arm.com> | 2023-10-10 11:22:59 +0200 |
---|---|---|
committer | Björn Davidsson <bjoern.davidsson@arm.com> | 2023-11-02 10:15:01 +0100 |
commit | 199e8e66ba3d959fd0f584683e5b1c1fda77ce6b (patch) | |
tree | f0b0d88dbebea983adac2b14c99664225d8823f7 /ethosu/vela/register_command_stream_generator.py | |
parent | 67daf2a3036608e60d7741f5bdf02196234ef85c (diff) | |
download | ethos-u-vela-199e8e66ba3d959fd0f584683e5b1c1fda77ce6b.tar.gz |
MLBEDSW-8117: Incorrect stride check for IFM/IFM2 and OFM
The constraint check for the IFM/IFM2/OFM strides were coded
according to an incorrect version of the specification.
Changed the check to verify that the strides are a multiple
of 16 bytes. Also changed the wording in the exception message
to clarify if it is a stride or value violating the constraint.
Test case had two stride settings violating the constraint,
after this change one of them still fails the check, so
no change to tests, except in comments clarifying what is
being tested.
Change-Id: I93815d8bb08303b5f747c947c0bbd461b12895e3
Signed-off-by: Björn Davidsson <bjoern.davidsson@arm.com>
Diffstat (limited to 'ethosu/vela/register_command_stream_generator.py')
-rw-r--r-- | ethosu/vela/register_command_stream_generator.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ethosu/vela/register_command_stream_generator.py b/ethosu/vela/register_command_stream_generator.py index 56aae73d..42ae99d5 100644 --- a/ethosu/vela/register_command_stream_generator.py +++ b/ethosu/vela/register_command_stream_generator.py @@ -81,7 +81,7 @@ from .register_command_stream_util import calc_blockdep from .register_command_stream_util import check_addresses from .register_command_stream_util import check_alignment from .register_command_stream_util import check_dma_op -from .register_command_stream_util import check_size +from .register_command_stream_util import check_length from .register_command_stream_util import check_strides from .register_command_stream_util import get_dma_memory_accesses from .register_command_stream_util import get_op_memory_accesses @@ -526,7 +526,7 @@ def generate_weights(emit: CommandStreamEmitter, weights: List[NpuAddressRange], ): if core < len(weights): check_alignment(weights[core].address, 16) - check_size(weights[core].length, 16) + check_length(weights[core].length, 16) emit.cmd1_with_address(addr, weights[core].address) emit.cmd1_with_offset(length, weights[core].length) elif core < arch.ncores: @@ -546,7 +546,7 @@ def generate_biases(emit: CommandStreamEmitter, biases: List[NpuAddressRange], a ): if core < len(biases): emit.cmd1_with_address(addr, biases[core].address) - check_size(biases[core].length, 16) + check_length(biases[core].length, 16) emit.cmd1_with_offset(length, biases[core].length) elif core < arch.ncores: emit.cmd1_with_address(addr, biases[0].address) |