diff options
| author | Mikael Olsson <mikael.olsson@arm.com> | 2023-06-13 12:17:04 +0200 |
|---|---|---|
| committer | Mikael Olsson <mikael.olsson@arm.com> | 2023-06-16 17:05:51 +0200 |
| commit | 09965b094429c45f4da273bb5c11f1c177acf9fd (patch) | |
| tree | 622bb8e2d9477c7b54d3a2eea7c57c3bb36f4939 /kernel/ethosu_capabilities.c | |
| parent | 252ed6a0f9af7a002d70a9c7644fec5b0b78ead5 (diff) | |
| download | ethos-u-linux-driver-stack-09965b094429c45f4da273bb5c11f1c177acf9fd.tar.gz | |
Add type check when getting message by ID
When the kernel driver handles incoming rpmsg messages, it uses the ID
in the message header to find the corresponding mailbox message. The
mailbox messages are stored as a generic message struct that is later
cast to the specific message type.
There is currently no type information stored in the generic message
struct so only the ID is used to distinguish between the mailbox
messages. This means if an incorrect ID is received that matches a
mailbox message with a different type, the kernel driver will cast the
message struct to the wrong type.
Type information has now been added to the generic message struct and
will be checked when trying to find the corresponding mailbox message so
both the ID and type must be correct to find a matching message.
Change-Id: Ifdbceea6ec4ae7078f424a32ce1ff5474bd22fef
Diffstat (limited to 'kernel/ethosu_capabilities.c')
| -rw-r--r-- | kernel/ethosu_capabilities.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/ethosu_capabilities.c b/kernel/ethosu_capabilities.c index 8611edf..83bd8cf 100644 --- a/kernel/ethosu_capabilities.c +++ b/kernel/ethosu_capabilities.c @@ -68,11 +68,12 @@ void ethosu_capability_rsp(struct ethosu_mailbox *mailbox, struct ethosu_mailbox_msg *msg; struct ethosu_capabilities *cap; - msg = ethosu_mailbox_find(mailbox, msg_id); + msg = ethosu_mailbox_find(mailbox, msg_id, + ETHOSU_CORE_MSG_CAPABILITIES_REQ); if (IS_ERR(msg)) { dev_warn(dev, - "Id for capabilities msg not found. id=%d\n", - msg_id); + "Id for capabilities msg not found. Id=0x%0x: %ld\n", + msg_id, PTR_ERR(msg)); return; } |