diff options
| author | Mikael Olsson <mikael.olsson@arm.com> | 2023-08-24 13:20:31 +0200 |
|---|---|---|
| committer | Mikael Olsson <mikael.olsson@arm.com> | 2023-09-07 10:42:25 +0200 |
| commit | 891156d2756d8b39b189a0d816b609520882d02a (patch) | |
| tree | f8f7410d7870fad0e30e2af826d269221a23c3f9 /kernel/ethosu_buffer.c | |
| parent | 99429e1042a0fd9fb11a2f348eb36249161134ac (diff) | |
| download | ethos-u-linux-driver-stack-891156d2756d8b39b189a0d816b609520882d02a.tar.gz | |
Fix IOCTL calls returning the wrong value
In some cases, the IOCTL functions didn't update the return value
variable so the wrong value was returned from the IOCTL calls.
Change-Id: I56529f8fb03cec52dbc555d5ed3d4e68e4bfab70
Signed-off-by: Mikael Olsson <mikael.olsson@arm.com>
Diffstat (limited to 'kernel/ethosu_buffer.c')
| -rw-r--r-- | kernel/ethosu_buffer.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/kernel/ethosu_buffer.c b/kernel/ethosu_buffer.c index 9033f8b..e9575e7 100644 --- a/kernel/ethosu_buffer.c +++ b/kernel/ethosu_buffer.c @@ -120,7 +120,7 @@ static long ethosu_buffer_ioctl(struct file *file, struct ethosu_buffer *buf = file->private_data; struct device *dev = buf->dev; void __user *udata = (void __user *)arg; - int ret = -EINVAL; + int ret; ret = device_lock_interruptible(dev); if (ret) @@ -134,8 +134,10 @@ static long ethosu_buffer_ioctl(struct file *file, case ETHOSU_IOCTL_BUFFER_SET: { struct ethosu_uapi_buffer uapi; - if (copy_from_user(&uapi, udata, sizeof(uapi))) + if (copy_from_user(&uapi, udata, sizeof(uapi))) { + ret = -EFAULT; break; + } dev_info(dev, "Buffer ioctl: Buffer set. size=%u, offset=%u\n", @@ -154,8 +156,10 @@ static long ethosu_buffer_ioctl(struct file *file, "Buffer ioctl: Buffer get. size=%u, offset=%u\n", uapi.size, uapi.offset); - if (copy_to_user(udata, &uapi, sizeof(uapi))) + if (copy_to_user(udata, &uapi, sizeof(uapi))) { + ret = -EFAULT; break; + } ret = 0; break; @@ -163,6 +167,7 @@ static long ethosu_buffer_ioctl(struct file *file, default: { dev_err(dev, "Invalid ioctl. cmd=%u, arg=%lu", cmd, arg); + ret = -ENOIOCTLCMD; break; } } |