From a0de05689870ecede28ca91ea0c8474daa7f8d6a Mon Sep 17 00:00:00 2001 From: Finn Williams Date: Wed, 22 Apr 2020 12:27:37 +0100 Subject: IVGCVSW-4719 Remove possible zeros from SendStreamMetaDataPacket offsets Signed-off-by: Finn Williams Change-Id: I8d7ee408c4c73be9b42bb739254b95c476e0e38c --- src/profiling/SendCounterPacket.cpp | 47 +++++++++++++------------------------ 1 file changed, 16 insertions(+), 31 deletions(-) (limited to 'src/profiling/SendCounterPacket.cpp') diff --git a/src/profiling/SendCounterPacket.cpp b/src/profiling/SendCounterPacket.cpp index 24b86d4427..1ef5440f7b 100644 --- a/src/profiling/SendCounterPacket.cpp +++ b/src/profiling/SendCounterPacket.cpp @@ -10,7 +10,6 @@ #include #include #include -#include #include #include @@ -34,15 +33,12 @@ void SendCounterPacket::SendStreamMetaDataPacket() std::string softwareVersion(GetSoftwareVersion()); std::string processName = GetProcessName().substr(0, 60); - uint32_t infoSize = numeric_cast(info.size()) > 0 ? numeric_cast(info.size()) + 1 : 0; - uint32_t hardwareVersionSize = numeric_cast(hardwareVersion.size()) > 0 ? - numeric_cast(hardwareVersion.size()) + 1 : 0; - uint32_t softwareVersionSize = numeric_cast(softwareVersion.size()) > 0 ? - numeric_cast(softwareVersion.size()) + 1 : 0; - uint32_t processNameSize = numeric_cast(processName.size()) > 0 ? - numeric_cast(processName.size()) + 1 : 0; + uint32_t infoSize = numeric_cast(info.size()) + 1; + uint32_t hardwareVersionSize = numeric_cast(hardwareVersion.size()) + 1; + uint32_t softwareVersionSize = numeric_cast(softwareVersion.size()) + 1; + uint32_t processNameSize = numeric_cast(processName.size()) + 1; - uint32_t sizeUint32 = numeric_cast(sizeof(uint32_t)); + uint32_t sizeUint32 = sizeof(uint32_t); uint32_t headerSize = 2 * sizeUint32; uint32_t bodySize = 10 * sizeUint32; @@ -95,19 +91,19 @@ void SendCounterPacket::SendStreamMetaDataPacket() WriteUint32(writeBuffer, offset, numeric_cast(pid)); // pid offset += sizeUint32; uint32_t poolOffset = bodySize; - WriteUint32(writeBuffer, offset, infoSize ? poolOffset : 0); // offset_info + WriteUint32(writeBuffer, offset, poolOffset); // offset_info offset += sizeUint32; poolOffset += infoSize; - WriteUint32(writeBuffer, offset, hardwareVersionSize ? poolOffset : 0); // offset_hw_version + WriteUint32(writeBuffer, offset, poolOffset); // offset_hw_version offset += sizeUint32; poolOffset += hardwareVersionSize; - WriteUint32(writeBuffer, offset, softwareVersionSize ? poolOffset : 0); // offset_sw_version + WriteUint32(writeBuffer, offset, poolOffset); // offset_sw_version offset += sizeUint32; poolOffset += softwareVersionSize; - WriteUint32(writeBuffer, offset, processNameSize ? poolOffset : 0); // offset_process_name + WriteUint32(writeBuffer, offset, poolOffset); // offset_process_name offset += sizeUint32; poolOffset += processNameSize; - WriteUint32(writeBuffer, offset, packetVersionEntries ? poolOffset : 0); // offset_packet_version_table + WriteUint32(writeBuffer, offset, poolOffset); // offset_packet_version_table offset += sizeUint32; WriteUint32(writeBuffer, offset, 0); // reserved offset += sizeUint32; @@ -120,23 +116,12 @@ void SendCounterPacket::SendStreamMetaDataPacket() offset += infoSize; } - if (hardwareVersionSize) - { - memcpy(&writeBuffer->GetWritableData()[offset], hardwareVersion.c_str(), hardwareVersionSize); - offset += hardwareVersionSize; - } - - if (softwareVersionSize) - { - memcpy(&writeBuffer->GetWritableData()[offset], softwareVersion.c_str(), softwareVersionSize); - offset += softwareVersionSize; - } - - if (processNameSize) - { - memcpy(&writeBuffer->GetWritableData()[offset], processName.c_str(), processNameSize); - offset += processNameSize; - } + memcpy(&writeBuffer->GetWritableData()[offset], hardwareVersion.c_str(), hardwareVersionSize); + offset += hardwareVersionSize; + memcpy(&writeBuffer->GetWritableData()[offset], softwareVersion.c_str(), softwareVersionSize); + offset += softwareVersionSize; + memcpy(&writeBuffer->GetWritableData()[offset], processName.c_str(), processNameSize); + offset += processNameSize; if (packetVersionEntries) { -- cgit v1.2.1