From 04cd60384f5fc8455bb7cf64416daa7b001754d1 Mon Sep 17 00:00:00 2001 From: James Conroy Date: Wed, 20 Apr 2022 17:16:50 +0100 Subject: IVGCVSW-6924 Fix shellcheck warnings * Fix shellcheck warnings, some have been suppressed using shellcheck ignore. Change-Id: Icae175a42bb348a58befb296949edca51713e977 Signed-off-by: James Conroy --- docker/armnn-android/docker-entrypoint.sh | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) (limited to 'docker/armnn-android') diff --git a/docker/armnn-android/docker-entrypoint.sh b/docker/armnn-android/docker-entrypoint.sh index 3a8258937b..b0bf1dcaa2 100644 --- a/docker/armnn-android/docker-entrypoint.sh +++ b/docker/armnn-android/docker-entrypoint.sh @@ -67,14 +67,15 @@ fi # Check Compute Library changes from repo cd ${dComputeLib} -if [ $(git rev-parse HEAD) = $(git ls-remote $(git rev-parse --abbrev-ref @{u} | -sed 's/\// /g') | cut -f1) ] +# shellcheck disable=SC1083 +if [ "$(git rev-parse HEAD)" = "$(git ls-remote "$(git rev-parse --abbrev-ref @{u} | +sed 's/\// /g')" | cut -f1)" ] then echo "Compute Lib Up-to-date" else echo "New changes are availble for Compute Library repo." echo "Do you wanna update (y/n)?" - read answer + read -r answer if [ "$answer" != "${answer#[Yy]}" ] ;then updateComputeLib fi @@ -82,8 +83,9 @@ fi # Check Tensorflow changes from repo cd ${dTensorflow} -if [ $(git rev-parse HEAD) = $(git ls-remote $(git rev-parse --abbrev-ref @{u} | -sed 's/\// /g') | cut -f1) ] +# shellcheck disable=SC1083 +if [ "$(git rev-parse HEAD)" = "$(git ls-remote "$(git rev-parse --abbrev-ref @{u} | +sed 's/\// /g')" | cut -f1)" ] then echo "Tensrflow Lib Up-to-date" else @@ -99,15 +101,16 @@ fi # Check FlatBuffer changes from repo cd ${dFlatBuffer} -if [ $(git rev-parse HEAD) = $(git ls-remote $(git rev-parse --abbrev-ref @{u} | -sed 's/\// /g') | cut -f1) ] +# shellcheck disable=SC1083 +if [ "$(git rev-parse HEAD)" = "$(git ls-remote "$(git rev-parse --abbrev-ref @{u} | +sed 's/\// /g')" | cut -f1)" ] then echo "FlatBuffer Up-to-date" else echo "FlatBuffer Not Up-to-date" echo "New changes are availble for Compute Library repo." echo "Do you wanna update (y/n)?" - read answer + read -r answer if [ "$answer" != "${answer#[Yy]}" ] ;then updateFlatBuffer fi -- cgit v1.2.1