From 223aba9ff116ecc7db7963ddb6a7213eee04b18c Mon Sep 17 00:00:00 2001 From: Michele Di Giorgio Date: Wed, 28 Apr 2021 16:03:32 +0100 Subject: Remove stale/solved TODOs Change-Id: I5c440f4c6ca4186adcfa926e6b7d924086671f29 Signed-off-by: Michele Di Giorgio Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5520 Tested-by: Arm Jenkins Reviewed-by: Manuel Bottini Comments-Addressed: Arm Jenkins --- tests/datasets/SmallConvolutionLayerDataset.h | 3 +-- tests/validation/CL/NormalizationLayer.cpp | 2 -- tests/validation/NEON/GEMM.cpp | 4 +--- tests/validation/fixtures/GEMMLowpFixture.h | 1 - 4 files changed, 2 insertions(+), 8 deletions(-) (limited to 'tests') diff --git a/tests/datasets/SmallConvolutionLayerDataset.h b/tests/datasets/SmallConvolutionLayerDataset.h index 66640dd943..7d1db5a73e 100644 --- a/tests/datasets/SmallConvolutionLayerDataset.h +++ b/tests/datasets/SmallConvolutionLayerDataset.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2020 Arm Limited. + * Copyright (c) 2017-2021 Arm Limited. * * SPDX-License-Identifier: MIT * @@ -181,7 +181,6 @@ public: } }; -// TODO (COMPMID-1749) class SmallConvolutionLayerReducedDataset final : public ConvolutionLayerDataset { public: diff --git a/tests/validation/CL/NormalizationLayer.cpp b/tests/validation/CL/NormalizationLayer.cpp index b1c28ad644..8c1890842b 100644 --- a/tests/validation/CL/NormalizationLayer.cpp +++ b/tests/validation/CL/NormalizationLayer.cpp @@ -62,8 +62,6 @@ const auto NormalizationDatasetFP32 = combine(combine(combine(framework::dataset TEST_SUITE(CL) TEST_SUITE(NormalizationLayer) -//TODO(COMPMID-415): Missing configuration? - // *INDENT-OFF* // clang-format off DATA_TEST_CASE(Validate, framework::DatasetMode::ALL, zip(zip(zip( diff --git a/tests/validation/NEON/GEMM.cpp b/tests/validation/NEON/GEMM.cpp index 2d8c61164b..500c6029d5 100644 --- a/tests/validation/NEON/GEMM.cpp +++ b/tests/validation/NEON/GEMM.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2020 Arm Limited. + * Copyright (c) 2017-2021 Arm Limited. * * SPDX-License-Identifier: MIT * @@ -188,8 +188,6 @@ TEST_SUITE_END() // U8 TEST_SUITE_END() // INTERLEAVE_4X4 -//TODO(COMPMID-415): Validate valid region - template using NEGEMMFixture = GEMMValidationFixture; diff --git a/tests/validation/fixtures/GEMMLowpFixture.h b/tests/validation/fixtures/GEMMLowpFixture.h index c3da2e261d..9e5eb53381 100644 --- a/tests/validation/fixtures/GEMMLowpFixture.h +++ b/tests/validation/fixtures/GEMMLowpFixture.h @@ -126,7 +126,6 @@ TensorType compute_gemmlowp_target(const TensorShape &shape_a, const TensorShape // Create and configure function // The GEMMinfo includes the values of the depth in case of reinterpreted 3d input/output FunctionType gemmlowp; - // TODO (COMPMID-1672) - Extending the test to validate add bias in offset contribution gemmlowp.configure(&a, &b, is_fused ? &bias : nullptr, &output, GEMMInfo(false, false, false, (reinterpret_output_as_3d ? shape_output[2] : 0), reinterpret_input_as_3d, false, output_stage)); ARM_COMPUTE_EXPECT(a.info()->is_resizable(), framework::LogLevel::ERRORS); -- cgit v1.2.1