From c1a72451273ec019e3e74c4b53ea847afe8ddf7c Mon Sep 17 00:00:00 2001 From: Georgios Pinitas Date: Fri, 24 Aug 2018 11:25:32 +0100 Subject: COMPMID-1332: Implement Slice for CL Change-Id: I0dbc4fd7f640d31daa1970eb3da0e941cb771f2b Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/146145 Tested-by: Jenkins Reviewed-by: Giorgio Arena Reviewed-by: Michalis Spyrou --- tests/validation/reference/SliceOperations.cpp | 137 +++++++++++++++++++++++++ tests/validation/reference/SliceOperations.h | 48 +++++++++ tests/validation/reference/StridedSlice.cpp | 92 ----------------- tests/validation/reference/StridedSlice.h | 45 -------- 4 files changed, 185 insertions(+), 137 deletions(-) create mode 100644 tests/validation/reference/SliceOperations.cpp create mode 100644 tests/validation/reference/SliceOperations.h delete mode 100644 tests/validation/reference/StridedSlice.cpp delete mode 100644 tests/validation/reference/StridedSlice.h (limited to 'tests/validation/reference') diff --git a/tests/validation/reference/SliceOperations.cpp b/tests/validation/reference/SliceOperations.cpp new file mode 100644 index 0000000000..04b5b98453 --- /dev/null +++ b/tests/validation/reference/SliceOperations.cpp @@ -0,0 +1,137 @@ +/* + * Copyright (c) 2018 ARM Limited. + * + * SPDX-License-Identifier: MIT + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in all + * copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE + * SOFTWARE. + */ +#include "SliceOperations.h" + +#include "arm_compute/core/utils/helpers/tensor_transform.h" + +namespace arm_compute +{ +namespace test +{ +namespace validation +{ +namespace reference +{ +template +SimpleTensor slice(const SimpleTensor &src, Coordinates starts, Coordinates ends) +{ + using namespace arm_compute::helpers::tensor_transform; + + // Validation checks + ARM_COMPUTE_ERROR_ON(src.shape().num_dimensions() > 4); + ARM_COMPUTE_ERROR_ON(starts.num_dimensions() > src.shape().num_dimensions()); + ARM_COMPUTE_ERROR_ON(std::any_of(starts.cbegin(), starts.cbegin() + starts.num_dimensions(), [](int i) + { + return i < 0; + })); + ARM_COMPUTE_ERROR_ON(ends.num_dimensions() > src.shape().num_dimensions()); + + // Get source shape + const TensorShape &src_shape = src.shape(); + + // Get actual end + Coordinates ends_abs = slice_absolute_end_coords(src_shape, ends); + + // Get destination shape + TensorShape dst_shape = compute_slice_output_shape(src_shape, starts, ends_abs); + + // Create destination tensor + SimpleTensor dst{ dst_shape, src.data_type(), 1 }; + + // Perform slice + Window win; + win.use_tensor_dimensions(dst_shape); + execute_window_loop(win, [&](const Coordinates & id) + { + Coordinates offset; + for(unsigned int i = 0; i < id.num_dimensions(); ++i) + { + offset.set(i, starts[i] + id[i]); + } + *reinterpret_cast(dst(id)) = *reinterpret_cast(src(offset)); + }); + + return dst; +} + +template SimpleTensor slice(const SimpleTensor &src, Coordinates starts, Coordinates ends); +template SimpleTensor slice(const SimpleTensor &src, Coordinates starts, Coordinates ends); + +template +SimpleTensor strided_slice(const SimpleTensor &src, + Coordinates starts, Coordinates ends, BiStrides strides, + int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask) +{ + using namespace arm_compute::helpers::tensor_transform; + + // Validation checks + ARM_COMPUTE_ERROR_ON(src.shape().num_dimensions() > 4); + ARM_COMPUTE_ERROR_ON(starts.num_dimensions() > src.shape().num_dimensions()); + ARM_COMPUTE_ERROR_ON(ends.num_dimensions() > src.shape().num_dimensions()); + ARM_COMPUTE_ERROR_ON(strides.num_dimensions() > src.shape().num_dimensions()); + ARM_COMPUTE_ERROR_ON(std::any_of(strides.cbegin(), strides.cbegin() + strides.num_dimensions(), [](int i) + { + return i == 0; + })); + + // Get source shape + const TensorShape &src_shape = src.shape(); + + // Get actual start, end coordinates and strides + const Coordinates final_strides = strided_slice_strides(src_shape, strides); + const Coordinates starts_abs = strided_slice_absolute_start_coords(src_shape, starts, final_strides, begin_mask); + const Coordinates ends_abs = strided_slice_absolute_end_coords(src_shape, starts_abs, ends, final_strides, end_mask, shrink_axis_mask); + + // Get destination shape + const TensorShape dst_shape = compute_strided_slice_output_shape(src_shape, starts_abs, ends_abs, final_strides); + + // Create destination tensor + SimpleTensor dst{ dst_shape, src.data_type(), 1 }; + + // Perform strided slice + Window win; + win.use_tensor_dimensions(dst_shape); + execute_window_loop(win, [&](const Coordinates & id) + { + Coordinates offset; + for(unsigned int i = 0; i < id.num_dimensions(); ++i) + { + offset.set(i, starts_abs[i] + id[i] * final_strides[i]); + } + *reinterpret_cast(dst(id)) = *reinterpret_cast(src(offset)); + }); + + return dst; +} + +template SimpleTensor strided_slice(const SimpleTensor &src, + Coordinates starts, Coordinates ends, BiStrides strides, + int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask); +template SimpleTensor strided_slice(const SimpleTensor &src, + Coordinates starts, Coordinates ends, BiStrides strides, + int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask); +} // namespace reference +} // namespace validation +} // namespace test +} // namespace arm_compute diff --git a/tests/validation/reference/SliceOperations.h b/tests/validation/reference/SliceOperations.h new file mode 100644 index 0000000000..89fe2038ed --- /dev/null +++ b/tests/validation/reference/SliceOperations.h @@ -0,0 +1,48 @@ +/* + * Copyright (c) 2018 ARM Limited. + * + * SPDX-License-Identifier: MIT + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in all + * copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE + * SOFTWARE. + */ +#ifndef __ARM_COMPUTE_TEST_SLICE_OPERATIONS_H__ +#define __ARM_COMPUTE_TEST_SLICE_OPERATIONS_H__ + +#include "tests/SimpleTensor.h" + +namespace arm_compute +{ +namespace test +{ +namespace validation +{ +namespace reference +{ +template +SimpleTensor slice(const SimpleTensor &src, Coordinates starts, Coordinates ends); + +template +SimpleTensor strided_slice(const SimpleTensor &src, + Coordinates starts, Coordinates ends, BiStrides strides, + int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask); +} // namespace reference +} // namespace validation +} // namespace test +} // namespace arm_compute +#endif /* __ARM_COMPUTE_TEST_SLICE_OPERATIONS_H__ */ diff --git a/tests/validation/reference/StridedSlice.cpp b/tests/validation/reference/StridedSlice.cpp deleted file mode 100644 index ac02ce1e71..0000000000 --- a/tests/validation/reference/StridedSlice.cpp +++ /dev/null @@ -1,92 +0,0 @@ -/* - * Copyright (c) 2018 ARM Limited. - * - * SPDX-License-Identifier: MIT - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in all - * copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE - * SOFTWARE. - */ -#include "StridedSlice.h" - -#include "arm_compute/core/utils/helpers/tensor_transform.h" - -namespace arm_compute -{ -namespace test -{ -namespace validation -{ -namespace reference -{ -template -SimpleTensor strided_slice(const SimpleTensor &src, - Coordinates starts, Coordinates ends, BiStrides strides, - int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask) -{ - using namespace arm_compute::helpers::tensor_transform; - - // Validation checks - ARM_COMPUTE_ERROR_ON(src.shape().num_dimensions() > 4); - ARM_COMPUTE_ERROR_ON(starts.num_dimensions() > src.shape().num_dimensions()); - ARM_COMPUTE_ERROR_ON(ends.num_dimensions() > src.shape().num_dimensions()); - ARM_COMPUTE_ERROR_ON(strides.num_dimensions() > src.shape().num_dimensions()); - for(unsigned int i = 0; i < strides.num_dimensions(); ++i) - { - ARM_COMPUTE_ERROR_ON(strides[i] == 0); - } - - // Get source shape - const TensorShape &src_shape = src.shape(); - - // Get actual start, end coordinates and strides - const Coordinates final_strides = strided_slice_strides(src_shape, strides); - const Coordinates starts_abs = strided_slice_absolute_start_coords(src_shape, starts, final_strides, begin_mask); - const Coordinates ends_abs = strided_slice_absolute_end_coords(src_shape, starts_abs, ends, final_strides, end_mask, shrink_axis_mask); - - // Get destination shape - const TensorShape dst_shape = compute_strided_slice_output_shape(src_shape, starts_abs, ends_abs, final_strides); - - // Create destination tensor - SimpleTensor dst{ dst_shape, src.data_type(), 1 }; - - // Perform strided slice - Window win; - win.use_tensor_dimensions(dst_shape); - execute_window_loop(win, [&](const Coordinates & id) - { - Coordinates offset; - for(unsigned int i = 0; i < id.num_dimensions(); ++i) - { - offset.set(i, starts_abs[i] + id[i] * final_strides[i]); - } - *reinterpret_cast(dst(id)) = *reinterpret_cast(src(offset)); - }); - - return dst; -} - -template SimpleTensor strided_slice(const SimpleTensor &src, - Coordinates starts, Coordinates ends, BiStrides strides, - int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask); -template SimpleTensor strided_slice(const SimpleTensor &src, - Coordinates starts, Coordinates ends, BiStrides strides, - int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask); -} // namespace reference -} // namespace validation -} // namespace test -} // namespace arm_compute diff --git a/tests/validation/reference/StridedSlice.h b/tests/validation/reference/StridedSlice.h deleted file mode 100644 index 805b7e65da..0000000000 --- a/tests/validation/reference/StridedSlice.h +++ /dev/null @@ -1,45 +0,0 @@ -/* - * Copyright (c) 2018 ARM Limited. - * - * SPDX-License-Identifier: MIT - * - * Permission is hereby granted, free of charge, to any person obtaining a copy - * of this software and associated documentation files (the "Software"), to - * deal in the Software without restriction, including without limitation the - * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or - * sell copies of the Software, and to permit persons to whom the Software is - * furnished to do so, subject to the following conditions: - * - * The above copyright notice and this permission notice shall be included in all - * copies or substantial portions of the Software. - * - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE - * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, - * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE - * SOFTWARE. - */ -#ifndef __ARM_COMPUTE_TEST_STRIDED_SLICE_H__ -#define __ARM_COMPUTE_TEST_STRIDED_SLICE_H__ - -#include "tests/SimpleTensor.h" - -namespace arm_compute -{ -namespace test -{ -namespace validation -{ -namespace reference -{ -template -SimpleTensor strided_slice(const SimpleTensor &src, - Coordinates starts, Coordinates ends, BiStrides strides, - int32_t begin_mask, int32_t end_mask, int32_t shrink_axis_mask); -} // namespace reference -} // namespace validation -} // namespace test -} // namespace arm_compute -#endif /* __ARM_COMPUTE_TEST_STRIDED_SLICE_H__ */ -- cgit v1.2.1