From 5ae9b694e5d154a2ab3ec0d448394eb5de49368e Mon Sep 17 00:00:00 2001 From: Michalis Spyrou Date: Mon, 5 Feb 2018 14:59:54 +0000 Subject: COMPMID-885 Valgrind NEConvolutionSquare::configure relies on uninitialised values Change-Id: I7a9a694064db8a92b2f8d4ea46e42070da6ed15a Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/118904 Tested-by: Jenkins Reviewed-by: Georgios Pinitas --- tests/validation/NEON/Convolution.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'tests/validation/NEON/Convolution.cpp') diff --git a/tests/validation/NEON/Convolution.cpp b/tests/validation/NEON/Convolution.cpp index 32df51abba..5545b7f574 100644 --- a/tests/validation/NEON/Convolution.cpp +++ b/tests/validation/NEON/Convolution.cpp @@ -66,7 +66,7 @@ DATA_TEST_CASE(Configuration, framework::DatasetMode::ALL, combine(combine(combi Tensor dst = create_tensor(shape, output_data_type); // Create conv matrix - int16_t conv[9]; + int16_t conv[9] = {}; ARM_COMPUTE_EXPECT(src.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(dst.info()->is_resizable(), framework::LogLevel::ERRORS); @@ -150,7 +150,7 @@ DATA_TEST_CASE(Configuration, framework::DatasetMode::ALL, combine(combine(combi Tensor dst = create_tensor(shape, output_data_type); // Create conv matrix - int16_t conv[25]; + int16_t conv[25] = {}; ARM_COMPUTE_EXPECT(src.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(dst.info()->is_resizable(), framework::LogLevel::ERRORS); @@ -234,7 +234,7 @@ DATA_TEST_CASE(Configuration, framework::DatasetMode::ALL, combine(combine(combi Tensor dst = create_tensor(shape, output_data_type); // Create conv matrix - int16_t conv[49]; + int16_t conv[49] = {}; ARM_COMPUTE_EXPECT(src.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(dst.info()->is_resizable(), framework::LogLevel::ERRORS); @@ -318,7 +318,7 @@ DATA_TEST_CASE(Configuration, framework::DatasetMode::ALL, combine(combine(combi Tensor dst = create_tensor(shape, output_data_type); // Create conv matrix - int16_t conv[81]; + int16_t conv[81] = {}; ARM_COMPUTE_EXPECT(src.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(dst.info()->is_resizable(), framework::LogLevel::ERRORS); @@ -404,14 +404,14 @@ shape, output_data_type, border_mode, filter_width, filter_height) Tensor dst = create_tensor(shape, output_data_type); // Create conv matrix - int16_t conv[filter_width * filter_height]; + std::vector conv(filter_height * filter_width); ARM_COMPUTE_EXPECT(src.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(dst.info()->is_resizable(), framework::LogLevel::ERRORS); // Create and configure function NEConvolutionRectangle convolution; - convolution.configure(&src, &dst, conv, filter_width, filter_height, 1, border_mode); + convolution.configure(&src, &dst, conv.data(), filter_width, filter_height, 1, border_mode); // Validate valid region const ValidRegion dst_valid_region = shape_to_valid_region(shape, (border_mode == BorderMode::UNDEFINED), BorderSize(filter_height / 2, filter_width / 2)); -- cgit v1.2.1