From cf3fe9403d8961caf9c9276ce7231c0f45cfe223 Mon Sep 17 00:00:00 2001 From: Michele Di Giorgio Date: Wed, 29 Aug 2018 10:41:54 +0100 Subject: COMPMID-1545: Fix FP16 CLRNNLayer mismatches Still failing on S7 edge. Using absolute tolerance when relative tolerance is not enough. Change-Id: Iadcbc6e58eb80261c3f8e75e6fa43701c6ec854c Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/145973 Reviewed-by: Georgios Pinitas Tested-by: Jenkins --- tests/validation/CL/RNNLayer.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'tests/validation/CL') diff --git a/tests/validation/CL/RNNLayer.cpp b/tests/validation/CL/RNNLayer.cpp index 5d518f9d9b..5ae38fb4b7 100644 --- a/tests/validation/CL/RNNLayer.cpp +++ b/tests/validation/CL/RNNLayer.cpp @@ -39,8 +39,9 @@ namespace validation { namespace { -RelativeTolerance tolerance_f32(0.001f); -RelativeTolerance tolerance_f16(half(0.2)); +RelativeTolerance tolerance_f32(0.001f); /**< Relative tolerance value for comparing reference's output against implementation's output for DataType:F32 */ +RelativeTolerance rel_tolerance_f16(half(0.2)); /**< Relative tolerance value for comparing reference's output against implementation's output for DataType:F16 */ +constexpr float abs_tolerance_f16(0.02f); /**< Absolute tolerance value for comparing reference's output against implementation's output for DataType:F16 */ } // namespace TEST_SUITE(CL) @@ -128,7 +129,7 @@ TEST_SUITE(FP16) FIXTURE_DATA_TEST_CASE(RunSmall, CLRNNLayerFixture, framework::DatasetMode::ALL, combine(datasets::SmallRNNLayerDataset(), framework::dataset::make("DataType", DataType::F16))) { // Validate output - validate(CLAccessor(_target), _reference, tolerance_f16); + validate(CLAccessor(_target), _reference, rel_tolerance_f16, 0.f, abs_tolerance_f16); } TEST_SUITE_END() // FP16 TEST_SUITE_END() // RNNLayer -- cgit v1.2.1