From 35c37940deb0f2cb2d1f074bb7f43f0485a885d2 Mon Sep 17 00:00:00 2001 From: Michele Di Giorgio Date: Tue, 3 Dec 2019 19:34:30 +0000 Subject: COMPMID-2974: VTS Test failure in CLConvolutionLayer quantized per-channel with multiplier == 1 Change-Id: I568aa17390af6eeef115171b6103703644b42762 Signed-off-by: Michele Di Giorgio Reviewed-on: https://review.mlplatform.org/c/2410 Comments-Addressed: Arm Jenkins Reviewed-by: Georgios Pinitas Tested-by: Arm Jenkins --- src/core/utils/quantization/AsymmHelpers.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'src/core/utils/quantization/AsymmHelpers.cpp') diff --git a/src/core/utils/quantization/AsymmHelpers.cpp b/src/core/utils/quantization/AsymmHelpers.cpp index 0551874d5f..6196662441 100644 --- a/src/core/utils/quantization/AsymmHelpers.cpp +++ b/src/core/utils/quantization/AsymmHelpers.cpp @@ -37,7 +37,7 @@ constexpr float epsilon = 0.00001f; Status calculate_quantized_multiplier(float multiplier, int *quant_multiplier, int *shift) { - if(multiplier > 1.f) + if(multiplier >= 1.f) { Status status = calculate_quantized_multiplier_greater_than_one(multiplier, quant_multiplier, shift); *shift *= -1; @@ -57,13 +57,6 @@ Status calculate_quantized_multiplier_less_than_one(float multiplier, ARM_COMPUTE_RETURN_ERROR_ON(right_shift == nullptr); ARM_COMPUTE_RETURN_ERROR_ON(multiplier < -epsilon); ARM_COMPUTE_RETURN_ERROR_ON(multiplier > 1.0f + epsilon); - if(std::fabs(1.0f - multiplier) < epsilon) - { - *quant_multiplier = 1; - *right_shift = 0; - return Status{}; - } - if(std::fabs(0.0f - multiplier) < epsilon) { *quant_multiplier = 0; -- cgit v1.2.1