From 760b494acdd6c0184e15b86e40256b27d6312b7a Mon Sep 17 00:00:00 2001 From: Pablo Marquez Tello Date: Thu, 27 May 2021 15:07:29 +0100 Subject: Fixed the compiler warning -Werror=type-limits * Comparison is always false due to limited range of data type. * rescale_value is truncated to int32_t and then is compared agains (1ll <<31) which will be always false * Resolves MLCE-508 Change-Id: I8dfd04b16beb5c2c3994eb817ed7a992fb63ed31 Signed-off-by: Pablo Marquez Tello Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5741 Reviewed-by: Michele Di Giorgio Reviewed-by: Manuel Bottini Comments-Addressed: Arm Jenkins Tested-by: Arm Jenkins --- .../kernels/a64_s8_nhwc_avg_generic_depthfirst/generic.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/core/NEON') diff --git a/src/core/NEON/kernels/arm_conv/pooling/kernels/a64_s8_nhwc_avg_generic_depthfirst/generic.cpp b/src/core/NEON/kernels/arm_conv/pooling/kernels/a64_s8_nhwc_avg_generic_depthfirst/generic.cpp index 5d7391dc26..405ae66755 100644 --- a/src/core/NEON/kernels/arm_conv/pooling/kernels/a64_s8_nhwc_avg_generic_depthfirst/generic.cpp +++ b/src/core/NEON/kernels/arm_conv/pooling/kernels/a64_s8_nhwc_avg_generic_depthfirst/generic.cpp @@ -83,13 +83,13 @@ void a64_s8_nhwc_avg_generic_depthfirst_impl( shift_value--; f_rescale_value *= 2.0f; } - - rescale_value = static_cast(round(f_rescale_value * static_cast(1ll << 31))); - if (static_cast(rescale_value) == (1ll << 31)) + int64_t large_rescale_value = round(f_rescale_value * static_cast(1ll << 31)); + if (large_rescale_value == (1ll << 31)) { shift_value++; - rescale_value >>= 1; + large_rescale_value >>= 1; } + rescale_value = static_cast(large_rescale_value); } __asm__ __volatile__( -- cgit v1.2.1