From 551852fb43a5cf7ed9ac8679517b103e9af8a38f Mon Sep 17 00:00:00 2001 From: Georgios Pinitas Date: Thu, 29 Nov 2018 13:58:31 +0000 Subject: COMPMID-1451: Remove invalid bias inclusion in specialized function. Fixed Segfault by removing bias iterator from specialized function which assumes no bias being provided. Change-Id: Ic897435ee9427d4359e8ab989a03e951da0d7ce0 Reviewed-on: https://review.mlplatform.org/314 Reviewed-by: Anthony Barbier Tested-by: Arm Jenkins --- .../kernels/NEDirectConvolutionLayerOutputStageKernel.cpp | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) (limited to 'src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp') diff --git a/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp b/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp index d3ab5490a4..09836f1d6b 100644 --- a/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp +++ b/src/core/NEON/kernels/NEDirectConvolutionLayerOutputStageKernel.cpp @@ -431,21 +431,13 @@ void output_stage_nhwc(ITensor *input, const ITe uint8x16_t min = vdupq_n_u8(0); uint8x16_t max = vdupq_n_u8(255); - Window window_bias = window; - window_bias.set(Window::DimY, Window::Dimension(0, 0, 0)); - window_bias.set(Window::DimZ, Window::Dimension(0, 0, 0)); - window_bias.set(3, Window::Dimension(0, 0, 0)); - Iterator in(input, window); - Iterator bi(bias, window_bias); - Iterator out(output, window); execute_window_loop(window, [&](const Coordinates & id) { - // Get bias and pointer to input + // Get pointer to input const auto in_ptr = reinterpret_cast(in.ptr()); - // Accumulate bias int32x4x4_t v_in = { { @@ -459,7 +451,7 @@ void output_stage_nhwc(ITensor *input, const ITe const auto out_ptr = out.ptr(); vst1q_u8(out_ptr, finalize_quantization(v_in, result_fixedpoint_multiplier, result_shift, result_offset_after_shift_s32, min, max)); }, - in, bi, out); + in, out); } } // namespace -- cgit v1.2.1