From b9070a42a44ec1a0102e2f0b04523d2e96392903 Mon Sep 17 00:00:00 2001 From: Matthew Jackson Date: Thu, 22 Aug 2019 16:13:27 +0100 Subject: COMPMID-2605: Add asymmetric padding support for Deconvolution layer Change-Id: I63b773bdce25f1342ccd3a08ded623a1508f70fe Signed-off-by: Matthew Jackson Reviewed-on: https://review.mlplatform.org/c/1797 Comments-Addressed: Arm Jenkins Tested-by: Arm Jenkins Reviewed-by: Michele Di Giorgio Reviewed-by: Giuseppe Rossini --- .../CL/kernels/CLDeconvolutionLayerUpsampleKernel.cpp | 9 ++++----- .../CL/kernels/CLDeconvolutionReshapeOutputKernel.cpp | 17 ++++++----------- 2 files changed, 10 insertions(+), 16 deletions(-) (limited to 'src/core/CL') diff --git a/src/core/CL/kernels/CLDeconvolutionLayerUpsampleKernel.cpp b/src/core/CL/kernels/CLDeconvolutionLayerUpsampleKernel.cpp index 50f654680c..4ae9cabd1f 100644 --- a/src/core/CL/kernels/CLDeconvolutionLayerUpsampleKernel.cpp +++ b/src/core/CL/kernels/CLDeconvolutionLayerUpsampleKernel.cpp @@ -56,7 +56,6 @@ Status CLDeconvolutionLayerUpsampleKernel::validate(const ITensorInfo *input, co ARM_COMPUTE_RETURN_ERROR_ON(output->dimension(idx_w) == 0); ARM_COMPUTE_RETURN_ERROR_ON(output->dimension(idx_h) == 0); - ARM_COMPUTE_RETURN_ERROR_ON(!info.padding_is_symmetric()); ARM_COMPUTE_RETURN_ERROR_ON(input->dimension(idx_c) != output->dimension(idx_c)); for(size_t i = 3; i < Coordinates::num_max_dimensions; ++i) @@ -104,12 +103,12 @@ void CLDeconvolutionLayerUpsampleKernel::run(const Window &window, cl::CommandQu const size_t idx_w = get_data_layout_dimension_index(data_layout, DataLayoutDimension::WIDTH); const size_t idx_h = get_data_layout_dimension_index(data_layout, DataLayoutDimension::HEIGHT); - const int out_start_x = _info.pad().first; - const int out_end_x = _output->info()->dimension(idx_w) - _info.pad().first + _info.stride().first - 1; + const int out_start_x = _info.pad_left(); + const int out_end_x = _output->info()->dimension(idx_w) - _info.pad_right() + _info.stride().first - 1; const int out_step_x = _info.stride().first; - const int out_start_y = _info.pad().second; - const int out_end_y = _output->info()->dimension(idx_h) - _info.pad().second + _info.stride().second - 1; + const int out_start_y = _info.pad_top(); + const int out_end_y = _output->info()->dimension(idx_h) - _info.pad_bottom() + _info.stride().second - 1; const int out_step_y = _info.stride().second; switch(data_layout) diff --git a/src/core/CL/kernels/CLDeconvolutionReshapeOutputKernel.cpp b/src/core/CL/kernels/CLDeconvolutionReshapeOutputKernel.cpp index 71218f5b52..69e5eff213 100644 --- a/src/core/CL/kernels/CLDeconvolutionReshapeOutputKernel.cpp +++ b/src/core/CL/kernels/CLDeconvolutionReshapeOutputKernel.cpp @@ -40,8 +40,6 @@ Status validate_arguments(const ITensorInfo *input, const ITensorInfo *bias, con { ARM_COMPUTE_RETURN_ERROR_ON_NULLPTR(input, output, input_info, weights_info); const DataLayout data_layout = input_info->data_layout(); - const unsigned int stride_x = deconv_info.stride().first; - const unsigned int stride_y = deconv_info.stride().second; const size_t idx_w = get_data_layout_dimension_index(data_layout, DataLayoutDimension::WIDTH); const size_t idx_h = get_data_layout_dimension_index(data_layout, DataLayoutDimension::HEIGHT); @@ -77,8 +75,8 @@ Status validate_arguments(const ITensorInfo *input, const ITensorInfo *bias, con if(output->total_size() != 0) { - auto out_dims = deconvolution_output_dimensions(input_info->dimension(idx_w), input_info->dimension(idx_h), weights_info->dimension(idx_w), weights_info->dimension(idx_h), - 0, 0, stride_x, stride_y); + const PadStrideInfo stride_info(deconv_info.stride().first, deconv_info.stride().second); + auto out_dims = deconvolution_output_dimensions(input_info->dimension(idx_w), input_info->dimension(idx_h), weights_info->dimension(idx_w), weights_info->dimension(idx_h), stride_info); const TensorShape output_shape = misc::shape_calculator::compute_deconvolution_output_shape(out_dims, *input_info, *weights_info); @@ -92,14 +90,11 @@ std::pair validate_and_configure_window(const ITensorInfo *input ARM_COMPUTE_ERROR_ON_NULLPTR(input, output); const DataLayout data_layout = input_info->data_layout(); + const size_t idx_w = get_data_layout_dimension_index(data_layout, DataLayoutDimension::WIDTH); + const size_t idx_h = get_data_layout_dimension_index(data_layout, DataLayoutDimension::HEIGHT); + const PadStrideInfo stride_info(deconv_info.stride().first, deconv_info.stride().second); - const unsigned int stride_x = deconv_info.stride().first; - const unsigned int stride_y = deconv_info.stride().second; - const size_t idx_w = get_data_layout_dimension_index(data_layout, DataLayoutDimension::WIDTH); - const size_t idx_h = get_data_layout_dimension_index(data_layout, DataLayoutDimension::HEIGHT); - - auto out_dims = deconvolution_output_dimensions(input_info->dimension(idx_w), input_info->dimension(idx_h), weights_info->dimension(idx_w), weights_info->dimension(idx_h), - 0, 0, stride_x, stride_y); + auto out_dims = deconvolution_output_dimensions(input_info->dimension(idx_w), input_info->dimension(idx_h), weights_info->dimension(idx_w), weights_info->dimension(idx_h), stride_info); const TensorShape output_shape = misc::shape_calculator::compute_deconvolution_output_shape(out_dims, *input_info, *weights_info); -- cgit v1.2.1