From 72610dcf2d634c9c2919ad55245c5c91609e87eb Mon Sep 17 00:00:00 2001 From: Michele Di Giorgio Date: Wed, 18 Nov 2020 15:29:08 +0000 Subject: Remove 3rdparty submodule and internal_only build option MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove 3rdparty submodule and allow to build external tests, examples and benchmarks using the Compute Library test framework. In order to use this option, the external tests directory must have the following structure: EXTERNAL_TESTS_DIR: └── tests ├── benchmark │   ├── CL │   ├── datasets │   ├── fixtures │   └── NEON └── validation    ├── CL     ├── datasets     ├── fixtures     └── NEON Then, the user can build the library with `external_tests_dir=`. Also, remove internal_only build option". Without the 3rdparty submodule, this build option is no longer needed. Resolves: COMPMID-3417, COMPMID-3419 Change-Id: Ib7bf8ec7b9b9317fd82012a96bf4a7b0be846c1b Signed-off-by: Michele Di Giorgio Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4704 Reviewed-by: Georgios Pinitas Tested-by: Arm Jenkins Comments-Addressed: Arm Jenkins --- scripts/clang_tidy_rules.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'scripts/clang_tidy_rules.py') diff --git a/scripts/clang_tidy_rules.py b/scripts/clang_tidy_rules.py index 1e24b042de..ddf25384f2 100755 --- a/scripts/clang_tidy_rules.py +++ b/scripts/clang_tidy_rules.py @@ -11,8 +11,7 @@ def get_list_includes(): "src/core/NEON/kernels/assembly " \ "src/core/NEON/kernels/convolution/winograd " \ "include/linux include " \ - ". " \ - "3rdparty/include kernels".split() + ". ".split() def get_list_flags( filename, arch): assert arch in ["armv7", "aarch64"] @@ -64,7 +63,6 @@ def filter_clang_tidy_lines( lines ): ("Utils.h" in line and "no member named 'unmap' in 'arm_compute::Tensor'" in line) or ("Utils.h" in line and "no member named 'map' in 'arm_compute::Tensor'" in line) or ("CPUUtils.cpp" in line and "'asm/hwcap.h' file not found" in line) or - "3rdparty" in line or ("'arm_compute_version.embed' file not found" in line) ): print_context=False continue @@ -119,8 +117,7 @@ def filter_clang_tidy_lines( lines ): ("GCKernelLibrary.cpp" in line and "warning: do not declare C-style arrays" in line) or ("Utils.h" in line and "warning: Use of zero-allocated memory" in line) or ("NEDepthwiseConvolutionLayerNativeKernel.cpp" in line and "misc-non-private-member-variables-in-classes" in line) or # This is to prevent false positive, should be reassessed with the newer clang-tidy - ("NEDepthwiseConvolutionLayerNativeKernel.cpp" in line and "cppcoreguidelines-pro-type-member-init" in line) or # This is to prevent false positive, should be reassessed with the newer clang-tidy - "3rdparty" in line): + ("NEDepthwiseConvolutionLayerNativeKernel.cpp" in line and "cppcoreguidelines-pro-type-member-init" in line)): # This is to prevent false positive, should be reassessed with the newer clang-tidy print_context=False continue -- cgit v1.2.1