From 484e7b3724c0e77751b5bed05180271fd5376e5d Mon Sep 17 00:00:00 2001 From: Moritz Pflanzer Date: Wed, 9 Aug 2017 11:43:18 +0100 Subject: COMPMID-417: Cleanup NEON FullyConnectedLayer Change-Id: Ie02a0a1a28ca2771e29a5e6552242caf0f6db1cf Reviewed-on: http://mpd-gerrit.cambridge.arm.com/83555 Tested-by: Kaizen Reviewed-by: Anthony Barbier --- arm_compute/core/TensorShape.h | 15 +++++++++++++-- .../runtime/NEON/functions/NEFullyConnectedLayer.h | 7 +------ 2 files changed, 14 insertions(+), 8 deletions(-) (limited to 'arm_compute') diff --git a/arm_compute/core/TensorShape.h b/arm_compute/core/TensorShape.h index 6cf08de114..8d15c50220 100644 --- a/arm_compute/core/TensorShape.h +++ b/arm_compute/core/TensorShape.h @@ -137,8 +137,6 @@ public: return std::accumulate(_id.begin(), _id.end(), 1, std::multiplies()); } /** Collapses given dimension and above. - * - * @note Precondition: dimension < TensorShape::num_max_dimensions * * @param[in] dimension Size of the wanted dimension * @@ -146,9 +144,22 @@ public: */ size_t total_size_upper(size_t dimension) const { + ARM_COMPUTE_ERROR_ON(dimension >= TensorShape::num_max_dimensions); return std::accumulate(_id.begin() + dimension, _id.end(), 1, std::multiplies()); } + /** Compute size of dimensions lower than the given one. + * + * @param[in] dimension Upper boundary. + * + * @return The linear size of the collapsed dimensions. + */ + size_t total_size_lower(size_t dimension) const + { + ARM_COMPUTE_ERROR_ON(dimension > TensorShape::num_max_dimensions); + return std::accumulate(_id.begin(), _id.begin() + dimension, 1, std::multiplies()); + } + private: /** Remove trailing dimensions of size 1 from the reported number of dimensions. */ void apply_dimension_correction() diff --git a/arm_compute/runtime/NEON/functions/NEFullyConnectedLayer.h b/arm_compute/runtime/NEON/functions/NEFullyConnectedLayer.h index af571d1057..08099b8539 100644 --- a/arm_compute/runtime/NEON/functions/NEFullyConnectedLayer.h +++ b/arm_compute/runtime/NEON/functions/NEFullyConnectedLayer.h @@ -97,11 +97,6 @@ public: void run() override; private: - void configure_fc_fc_wb(const ITensor *input, const ITensor *weights, ITensor *output); - void configure_fc_fc_nb(const ITensor *input, const ITensor *weights, ITensor *output); - void configure_conv_fc_wb(const ITensor *input, const ITensor *weights, ITensor *output); - void configure_conv_fc_nb(const ITensor *input, const ITensor *weights, ITensor *output); - NEIm2ColKernel _im2col_kernel; NEFullyConnectedLayerReshapeWeights _reshape_weights_kernel; NEGEMMInterleave4x4Kernel _interleave4x4_kernel; @@ -111,8 +106,8 @@ private: Tensor _interleave4x4_output; Tensor _reshape_weights_output; bool _are_weights_reshaped; - bool _is_fc_after_conv; bool _is_batched_fc_layer; + bool _linearize_input; bool _accumulate_biases; }; } -- cgit v1.2.1