From 9637b2e4fc33b2264aa5586dd6b2ed1045db5075 Mon Sep 17 00:00:00 2001 From: Michele Di Giorgio Date: Mon, 23 Sep 2019 16:49:49 +0100 Subject: COMPMID-2671: Change ArgMinMax NEON/CL output type to Signed32 Change-Id: I718f3884928271c5b0afb259d5bfe9df284f18e6 Signed-off-by: Michele Di Giorgio Reviewed-on: https://review.mlplatform.org/c/1995 Reviewed-by: Georgios Pinitas Comments-Addressed: Arm Jenkins Tested-by: Arm Jenkins --- arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'arm_compute/runtime/CL') diff --git a/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h b/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h index b3a85948a8..2384ebcd37 100644 --- a/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h +++ b/arm_compute/runtime/CL/functions/CLArgMinMaxLayer.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018 ARM Limited. + * Copyright (c) 2018-2019 ARM Limited. * * SPDX-License-Identifier: MIT * @@ -32,7 +32,13 @@ namespace arm_compute { class ICLTensor; -/** Function to calculate the index of the minimum or maximum values in a tensor based on an axis. */ +/** Function to calculate the index of the minimum or maximum values in a + * tensor based on an axis. + * + * @note The indices are computed in unsigned 32-bit (U32). It is the user's + * responsibility to check that the results do not overflow in case the + * output data type is set to signed 32-bit integer (S32). + */ class CLArgMinMaxLayer : public ICLSimpleFunction { public: @@ -40,7 +46,7 @@ public: * * @param[in] input Input source tensor. Data types supported: F16/F32. * @param[in] axis Axis to find max/min index. - * @param[out] output Output source tensor. Data types supported: U32. + * @param[out] output Output source tensor. Data types supported: U32/S32. * @param[in] op Operation to perform: min or max */ void configure(const ICLTensor *input, int axis, ICLTensor *output, const ReductionOperation &op); @@ -48,7 +54,7 @@ public: * * @param[in] input Input source tensor info. Data types supported: F16/F32. * @param[in] axis Axis to find max/min index. - * @param[in] output Output source tensor info. Data types supported: U32. + * @param[in] output Output source tensor info. Data types supported: U32/S32. * @param[in] op Operation to perform: min or max * * @return a status -- cgit v1.2.1