From 7d61ff041826782d14e67b7f5b7a2864905ff38b Mon Sep 17 00:00:00 2001 From: Michele Di Giorgio Date: Mon, 18 Jan 2021 21:15:59 +0000 Subject: Make all CL Concatenate kernels and functions state-less Resolves COMPMID-3995 Change-Id: I84172bed20924f1d9ae3b4d14d7b321e9494296e Signed-off-by: Michele Di Giorgio Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4887 Tested-by: Arm Jenkins Reviewed-by: Georgios Pinitas --- .../runtime/CL/functions/CLConcatenateLayer.h | 69 ++++------------------ 1 file changed, 11 insertions(+), 58 deletions(-) (limited to 'arm_compute/runtime/CL/functions/CLConcatenateLayer.h') diff --git a/arm_compute/runtime/CL/functions/CLConcatenateLayer.h b/arm_compute/runtime/CL/functions/CLConcatenateLayer.h index 5e7003a112..bfc8a39ac9 100644 --- a/arm_compute/runtime/CL/functions/CLConcatenateLayer.h +++ b/arm_compute/runtime/CL/functions/CLConcatenateLayer.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018-2020 Arm Limited. + * Copyright (c) 2018-2021 Arm Limited. * * SPDX-License-Identifier: MIT * @@ -24,7 +24,6 @@ #ifndef ARM_COMPUTE_CLCONCATENATELAYER_H #define ARM_COMPUTE_CLCONCATENATELAYER_H -#include "arm_compute/runtime/CL/ICLOperator.h" #include "arm_compute/runtime/IFunction.h" #include "arm_compute/core/Types.h" @@ -43,10 +42,10 @@ class Status; /** Basic function to execute concatenate tensors along a given axis. This function calls the following kernels: * - * -# @ref CLWidthConcatenateLayerKernel (if underlying concatenation axis is 0). - * -# @ref CLHeightConcatenateLayerKernel (if underlying concatenation axis is 1). - * -# @ref CLDepthConcatenateLayerKernel (if underlying concatenation axis is 2). - * -# @ref CLBatchConcatenateLayerKernel (if underlying concatenation axis is 3). + * -# @ref opencl::kernels::ClWidthConcatenateKernel (if underlying concatenation axis is 0). + * -# @ref opencl::kernels::ClHeightConcatenateKernel (if underlying concatenation axis is 1). + * -# @ref opencl::kernels::ClDepthConcatenateKernel (if underlying concatenation axis is 2). + * -# @ref opencl::kernels::ClBatchConcatenateKernel (if underlying concatenation axis is 3). */ class CLConcatenateLayer : public IFunction { @@ -66,7 +65,8 @@ public: /** Initialise the kernel's inputs vector and output. * * @note Input and output tensor dimensions preconditions defer depending on the concatenation axis. - * @note Preconditions can be found respectively at @ref CLWidthConcatenateLayerKernel, @ref CLHeightConcatenateLayerKernel and @ref CLDepthConcatenateLayerKernel. + * @note Preconditions can be found respectively at @ref opencl::kernels::ClWidthConcatenateKernel, + * @ref opencl::kernels::ClHeightConcatenateKernel and @ref opencl::kernels::ClDepthConcatenateKernel. * * @param[in,out] inputs_vector The vectors containing all the tensors to concatenate. Data types supported: All * @param[out] output Output tensor. Data types supported: Same as @p input. @@ -76,7 +76,8 @@ public: /** Initialise the kernel's inputs vector and output. * * @note Input and output tensor dimensions preconditions defer depending on the concatenation axis. - * @note Preconditions can be found respectively at @ref CLWidthConcatenateLayerKernel, @ref CLHeightConcatenateLayerKernel and @ref CLDepthConcatenateLayerKernel. + * @note Preconditions can be found respectively at @ref opencl::kernels::ClWidthConcatenateKernel, + * @ref opencl::kernels::ClHeightConcatenateKernel and @ref opencl::kernels::ClDepthConcatenateKernel. * * @param[in] compile_context The compile context to be used. * @param[in,out] inputs_vector The vectors containing all the tensors to concatenate. Data types supported: All @@ -87,7 +88,8 @@ public: /** Static function to check if given info will lead to a valid configuration of @ref CLConcatenateLayer * * @note Input and output tensor dimensions preconditions defer depending on the concatenation axis. - * @note Preconditions can be found respectively at @ref CLWidthConcatenateLayerKernel, @ref CLHeightConcatenateLayerKernel and @ref CLDepthConcatenateLayerKernel. + * @note Preconditions can be found respectively at @ref opencl::kernels::ClWidthConcatenateKernel, + * @ref opencl::kernels::ClHeightConcatenateKernel and @ref opencl::kernels::ClDepthConcatenateKernel. * * @param[in] inputs_vector The vectors containing all the tensors info to concatenate. Data types supported: All. * @param[in] output Output tensor info. Data types supported: Same as @p input. @@ -104,54 +106,5 @@ private: struct Impl; std::unique_ptr _impl; }; - -namespace experimental -{ -/** Basic function to execute concatenate tensors along a given axis. This function calls the following kernels: - * - * -# @ref CLWidthConcatenateLayerKernel (if underlying concatenation axis is 0). - * -# @ref CLHeightConcatenateLayerKernel (if underlying concatenation axis is 1). - * -# @ref CLDepthConcatenateLayerKernel (if underlying concatenation axis is 2). - * -# @ref CLBatchConcatenateLayerKernel (if underlying concatenation axis is 3). - */ -class CLConcatenation : public ICLOperator -{ -public: - /** Default constructor */ - CLConcatenation(); - /** Initialise the kernel's inputs vector and output. - * - * @note Input and output tensor dimensions preconditions defer depending on the concatenation axis. - * @note Preconditions can be found respectively at @ref CLWidthConcatenateLayerKernel, @ref CLHeightConcatenateLayerKernel and @ref CLDepthConcatenateLayerKernel. - * - * - * @param[in] compile_context The compile context to be used. - * @param[in,out] inputs_vector The vectors containing all the tensors to concatenate. Data types supported: All - * @param[out] output Output tensor. Data types supported: Same as @p input. - * @param[in] axis Concatenation axis. Supported underlying concatenation axis are 0, 1, 2 and 3. - */ - void configure(const CLCompileContext &compile_context, const std::vector &inputs_vector, ITensorInfo *output, size_t axis); - /** Static function to check if given info will lead to a valid configuration of @ref NEConcatenateLayer - * - * @note Input and output tensor dimensions preconditions defer depending on the concatenation axis. - * @note Preconditions can be found respectively at @ref CLWidthConcatenateLayerKernel, @ref CLHeightConcatenateLayerKernel and @ref CLDepthConcatenateLayerKernel. - * - * @param[in] inputs_vector The vectors containing all the tensors info to concatenate. Data types supported: All - * @param[in] output Output tensor info. Data types supported: Same as @p input. - * @param[in] axis Concatenation axis. Supported underlying concatenation axis are 0, 1, 2 and 3. - * - * @return a status - */ - static Status validate(const std::vector &inputs_vector, const ITensorInfo *output, size_t axis); - - // Inherited methods overridden: - void run(ITensorPack &tensors) override; - -private: - std::vector> _concat_kernels; - unsigned int _num_inputs; - unsigned int _axis; -}; -} // namespace experimental } // namespace arm_compute #endif /* ARM_COMPUTE_CLCONCATENATELAYER_H */ -- cgit v1.2.1