From a62129a02397ba87171ebf4477795f628dcec0f6 Mon Sep 17 00:00:00 2001 From: Viet-Hoa Do Date: Wed, 26 Apr 2023 15:38:45 +0100 Subject: Fix fully connected and matmul mismatches * There is an issue with quantized fully connected and matmul when the lower bound of bounded ReLU is negative. * Use int32_t for the calculation of min/max quantized value rather than PixelValue to avoid this issue. Partially resolves: COMPMID-5996 Signed-off-by: Viet-Hoa Do Change-Id: I7b22e9d56a2441fc6a4c5c4e627f57d6e00d6ff1 Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/9502 Tested-by: Arm Jenkins Reviewed-by: Jakub Sujak Comments-Addressed: Arm Jenkins Benchmark: Arm Jenkins --- arm_compute/core/utils/quantization/AsymmHelpers.h | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'arm_compute/core/utils') diff --git a/arm_compute/core/utils/quantization/AsymmHelpers.h b/arm_compute/core/utils/quantization/AsymmHelpers.h index 9e1e9668fb..a9041762f5 100644 --- a/arm_compute/core/utils/quantization/AsymmHelpers.h +++ b/arm_compute/core/utils/quantization/AsymmHelpers.h @@ -82,18 +82,6 @@ Status calculate_quantized_multipliers(const QuantizationInfo &iq_info, */ std::pair get_min_max_values_from_quantized_data_type(DataType data_type); -/** Get minimum and maximum output of the activation function after quantization. - * - * Only ReLU, upper bounded ReLU and lower+upper bounded ReLU are supported. - * - * @param[in] q_info Output quantization info. - * @param[in] act_info Activation function information. - * @param[in] data_type Output data type (either QASYMM8 or QASYMM8_SIGNED). - * - * @return The minimum and maximum output of the activation function after quantization. - */ -std::tuple get_quantized_asymmetric_output_min_max(const QuantizationInfo &q_info, const ActivationLayerInfo &act_info, DataType data_type); - /** Compute quantized per-channel multipliers and shifts. As many multipliers * and shifts as output channels are computed. If weights are not quantized * per-channel, multipliers and shifts will end up being the same for each -- cgit v1.2.1