From 18e20ff8bc31bd835e96b46c0beb5435c76572bd Mon Sep 17 00:00:00 2001 From: Michalis Spyrou Date: Wed, 6 May 2020 17:03:59 +0100 Subject: COMPMID-3460: Refactor NEElementwiseUnaryKernel Removed most of the templates and refactored the code. Performance is the same but the libary size dropped by 52Kb. Change-Id: I41ff0c0853c923d925cdaeb05f4a58c9086fff94 Signed-off-by: Michalis Spyrou Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3190 Tested-by: Arm Jenkins Reviewed-by: Michele Di Giorgio Comments-Addressed: Arm Jenkins --- .../core/NEON/kernels/NEElementwiseUnaryKernel.h | 29 ++++++++++++---------- 1 file changed, 16 insertions(+), 13 deletions(-) (limited to 'arm_compute/core/NEON/kernels/NEElementwiseUnaryKernel.h') diff --git a/arm_compute/core/NEON/kernels/NEElementwiseUnaryKernel.h b/arm_compute/core/NEON/kernels/NEElementwiseUnaryKernel.h index 2a4a8f8e46..9a41cecf19 100644 --- a/arm_compute/core/NEON/kernels/NEElementwiseUnaryKernel.h +++ b/arm_compute/core/NEON/kernels/NEElementwiseUnaryKernel.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018-2019 ARM Limited. + * Copyright (c) 2018-2020 ARM Limited. * * SPDX-License-Identifier: MIT * @@ -78,23 +78,26 @@ public: // Inherited methods overridden: void run(const Window &window, const ThreadInfo &info) override; +private: /** Common signature for all the specialised arithmetic functions * - * @param[in] input An input tensor. Data types supported: F16/F32. - * @param[out] output The output tensor. Data types supported: F16/F32. - * @param[in] window Region on which to execute the kernel. + * @param[in] window Region on which to execute the kernel. */ - using ElementwiseUnaryFunction = void(const ITensor *input, ITensor *output, const Window &window); + using ElementwiseUnaryPtr = void (NEElementwiseUnaryKernel::*)(const Window &window); -protected: - // Inherited methods overridden: - static Status validate_arguments(ElementWiseUnary op, const ITensorInfo &input, const ITensorInfo &output); - - /** Function to use for the particular tensor types passed to configure() */ - std::function _function; + /** Template function to run elementwise unary operation + * + * @tparam ScalarType Scalar datatype + * + * @param[in] window Region on which to execute the kernel. (Must be a valid region of the window returned by window()). + */ + template + void elementwise_op(const Window &window); - const ITensor *_input; - ITensor *_output; + ElementwiseUnaryPtr _func; + const ITensor *_input; + ITensor *_output; + ElementWiseUnary _op; }; } // namespace arm_compute #endif /* ARM_COMPUTE_NEELEMENTWISEUNARYKERNEL_H */ -- cgit v1.2.1