From 911d5728fccdabbdf41549c58f0266e49c2aeaf0 Mon Sep 17 00:00:00 2001 From: Sunita Nadampalli Date: Tue, 2 May 2023 14:05:39 +0000 Subject: [scons multi_isa] extend multi_isa build to support armv8-a march This change adds support for multi isa build with armv8-a as the base micro architecture. To enable this, use 'arch=armv8a' and 'multi_isa=1' build flags during scons build. This build option doesn't include fp16 vector arithmetic. To include fp16 vector arithmetic, use 'arch=armv8.2-a' and 'multi_isa=1' build option. Signed-off-by: Sunita Nadampalli Change-Id: Ib5ca61dc65603382baee53b3ec30b2b817beda3c Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/9474 Tested-by: Arm Jenkins Comments-Addressed: Arm Jenkins Reviewed-by: SiCong Li Reviewed-by: Viet-Hoa Do Benchmark: Arm Jenkins --- SConstruct | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) (limited to 'SConstruct') diff --git a/SConstruct b/SConstruct index d6f15c0caf..f6c90c3098 100644 --- a/SConstruct +++ b/SConstruct @@ -98,7 +98,7 @@ vars.AddVariables( BoolVariable("examples", "Build example programs", True), BoolVariable("gemm_tuner", "Build gemm_tuner programs", True), BoolVariable("Werror", "Enable/disable the -Werror compilation flag", True), - BoolVariable("multi_isa", "Build Multi ISA binary version of library. Note works only for armv8.2-a", False), + BoolVariable("multi_isa", "Build Multi ISA binary version of library. Works for armv8a without the support for FP16 vector arithmetic. Use armv8.2-a or beyond to enable FP16 vector arithmetic support", False), BoolVariable("standalone", "Builds the tests as standalone executables, links statically with libgcc, libstdc++ and libarm_compute", False), BoolVariable("opencl", "Enable OpenCL support", True), BoolVariable("neon", "Enable Arm® Neon™ support", False), @@ -306,11 +306,15 @@ if env['multi_isa']: print("Currently Multi ISA binary is only supported for arm v8 family") Exit(1) - if 'v8.6-a' in env['arch']: - if "disable_mmla_fp" not in env['custom_options']: - env.Append(CPPDEFINES = ['ARM_COMPUTE_ENABLE_SVEF32MM']) + if 'v8a' in env['arch']: + print("INFO: multi_isa armv8-a architecture build doesn't enable __ARM_FEATURE_FP16_VECTOR_ARITHMETIC. Use armv8.2-a or beyond to enable FP16 vector arithmetic support") + env.Append(CXXFLAGS = ['-march=armv8-a']) # note: this will disable fp16 extension __ARM_FEATURE_FP16_VECTOR_ARITHMETIC + else: + if 'v8.6-a' in env['arch']: + if "disable_mmla_fp" not in env['custom_options']: + env.Append(CPPDEFINES = ['ARM_COMPUTE_ENABLE_SVEF32MM']) - env.Append(CXXFLAGS = ['-march=armv8.2-a+fp16']) # explicitly enable fp16 extension otherwise __ARM_FEATURE_FP16_VECTOR_ARITHMETIC is undefined + env.Append(CXXFLAGS = ['-march=armv8.2-a+fp16']) # explicitly enable fp16 extension otherwise __ARM_FEATURE_FP16_VECTOR_ARITHMETIC is undefined else: # NONE "multi_isa" builds -- cgit v1.2.1