From f25e295a9f52a4a48ae557820224f14e62ba006a Mon Sep 17 00:00:00 2001 From: Manuel Bottini Date: Thu, 23 Apr 2020 12:40:08 +0100 Subject: COMPMID-3329: failures in nightly (GC/GEMM and CPP/DFT) - Can't recreate GC/GEMM - Fix on CPP/DFT/DFT2D/Complex using the appropriate tolerance - Fix CPP/DFT/Conv/Real2Real by removing concurrency issue on faulty function Looking at the proper fix for CPP/DFT/Conv/Real2Real since it is a concurrency issue Change-Id: Ic846dc7925d4c1b47e14181656c905f90778cdeb Signed-off-by: Manuel Bottini Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3085 Tested-by: Arm Jenkins Comments-Addressed: Arm Jenkins Reviewed-by: Georgios Pinitas --- tests/validation/CPP/DFT.cpp | 4 ++-- tests/validation/reference/DFT.cpp | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/validation/CPP/DFT.cpp b/tests/validation/CPP/DFT.cpp index 8f1b82371d..d4020f2d99 100644 --- a/tests/validation/CPP/DFT.cpp +++ b/tests/validation/CPP/DFT.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2019 ARM Limited. + * Copyright (c) 2019-2020 ARM Limited. * * SPDX-License-Identifier: MIT * @@ -141,7 +141,7 @@ DATA_TEST_CASE(Complex, framework::DatasetMode::ALL, shapes_2d_dft, auto backward = reference::dft_2d(forward, reference::FFTDirection::Inverse); // Validate with input - validate(SimpleTensorAccessor(src), backward, RelativeTolerance(0.1f)); + validate(SimpleTensorAccessor(src), backward, RelativeTolerance(0.1f), 0.f, AbsoluteTolerance(0.001f)); } TEST_SUITE_END() // DFT2D diff --git a/tests/validation/reference/DFT.cpp b/tests/validation/reference/DFT.cpp index ae030c7104..7221312641 100644 --- a/tests/validation/reference/DFT.cpp +++ b/tests/validation/reference/DFT.cpp @@ -269,9 +269,7 @@ SimpleTensor complex_mul_and_reduce(const SimpleTensor &input, const Simpl // MemSet dst memory to zero std::memset(dst.data(), 0, dst.size()); -#if defined(_OPENMP) - #pragma omp parallel for collapse(5) -#endif /* _OPENMP */ + for(uint32_t b = 0; b < N; ++b) { for(uint32_t co = 0; co < Co; ++co) -- cgit v1.2.1