From ebab0f988fb5cefad0d3c8b9956e1def33950be5 Mon Sep 17 00:00:00 2001 From: Michele Di Giorgio Date: Mon, 17 Feb 2020 16:21:48 +0000 Subject: COMPMID-2819: Adding tolerance of 1 to CLColorConvert RGB8toU8 tests Both rounding-to-zero and rounding-to-nearest even generate mismatches with difference of 1 between reference and OpenCL implementation. Therefore, this patch adds a tolerance to the test. Change-Id: Id01a04c2b738ba0cc2981b675824cf3a838dc7e9 Signed-off-by: Michele Di Giorgio Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/2737 Reviewed-by: Georgios Pinitas Comments-Addressed: Arm Jenkins Tested-by: Georgios Pinitas --- tests/validation/CL/ColorConvert.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/validation/CL/ColorConvert.cpp b/tests/validation/CL/ColorConvert.cpp index 6bfe67b587..d4322fcff5 100644 --- a/tests/validation/CL/ColorConvert.cpp +++ b/tests/validation/CL/ColorConvert.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2019 ARM Limited. + * Copyright (c) 2017-2020 ARM Limited. * * SPDX-License-Identifier: MIT * @@ -41,6 +41,7 @@ namespace validation namespace { constexpr AbsoluteTolerance tolerance_nv(2); +constexpr AbsoluteTolerance tolerance_u8(1); // Input data sets const auto RGBDataset = framework::dataset::make("FormatType", { Format::RGB888, Format::RGBA8888 }); @@ -228,7 +229,7 @@ FIXTURE_DATA_TEST_CASE(RunSmall, CLColorConvertFixture, framework::Data // Validate output for(unsigned int plane_idx = 0; plane_idx < _dst_num_planes; ++plane_idx) { - validate(CLAccessor(*_target.cl_plane(plane_idx)), _reference[plane_idx]); + validate(CLAccessor(*_target.cl_plane(plane_idx)), _reference[plane_idx], tolerance_u8); } } FIXTURE_DATA_TEST_CASE(RunLarge, CLColorConvertFixture, framework::DatasetMode::NIGHTLY, combine(datasets::Large2DShapes(), ColorConvert_RGB_to_U8)) @@ -236,7 +237,7 @@ FIXTURE_DATA_TEST_CASE(RunLarge, CLColorConvertFixture, framework::Data // Validate output for(unsigned int plane_idx = 0; plane_idx < _dst_num_planes; ++plane_idx) { - validate(CLAccessor(*_target.cl_plane(plane_idx)), _reference[plane_idx]); + validate(CLAccessor(*_target.cl_plane(plane_idx)), _reference[plane_idx], tolerance_u8); } } TEST_SUITE_END() -- cgit v1.2.1