From dc12519582d06da9fac9c53300a5ab83a5b26632 Mon Sep 17 00:00:00 2001 From: Manuel Bottini Date: Tue, 11 Aug 2020 13:18:29 +0100 Subject: COMPMID-3699: Nightly failure CL DirectConvolution Tolerance issue Change-Id: I0246b70b03520b13a6a1bc5a92fb4787d7c0e734 Signed-off-by: Manuel Bottini Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/3711 Reviewed-by: SiCong Li Tested-by: Arm Jenkins Comments-Addressed: Arm Jenkins --- tests/validation/CL/DirectConvolutionLayer.cpp | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/validation/CL/DirectConvolutionLayer.cpp b/tests/validation/CL/DirectConvolutionLayer.cpp index 767da943f2..090bd22ed9 100644 --- a/tests/validation/CL/DirectConvolutionLayer.cpp +++ b/tests/validation/CL/DirectConvolutionLayer.cpp @@ -43,11 +43,11 @@ namespace validation { namespace { -// COMPMID-517 Investigate the mismatch to see whether it is a real bug -RelativeTolerance tolerance_fp16(half(0.2)); /**< Tolerance for floating point tests */ -RelativeTolerance tolerance_fp32(0.03f); /**< Tolerance for floating point tests */ -constexpr float tolerance_num = 0.07f; /**< Tolerance number */ -constexpr AbsoluteTolerance tolerance_qasymm8(1); /**< Tolerance for quantized tests */ +RelativeTolerance tolerance_fp16(half(0.2)); /**< Tolerance for floating point tests */ +RelativeTolerance tolerance_fp32(0.05f); /**< Tolerance for floating point tests */ +AbsoluteTolerance tolerance_fp32_abs(0.0003f); /**< Absolute Tolerance for floating point tests */ +constexpr float tolerance_num = 0.07f; /**< Tolerance number */ +constexpr AbsoluteTolerance tolerance_qasymm8(1); /**< Tolerance for quantized tests */ const auto data_strides = combine(framework::dataset::make("StrideX", 1, 3), framework::dataset::make("StrideY", 1, 3)); const auto data_strides_small = combine(framework::dataset::make("StrideX", 1), framework::dataset::make("StrideY", 1)); @@ -88,8 +88,6 @@ const auto ActivationFunctionsDataset = framework::dataset::make("ActivationInfo TEST_SUITE(CL) TEST_SUITE(DirectConvolutionLayer) -//TODO(COMPMID-415): Configuration tests? - // *INDENT-OFF* // clang-format off DATA_TEST_CASE(Validate, framework::DatasetMode::ALL, zip(zip(zip(zip(zip(zip( @@ -238,7 +236,7 @@ FIXTURE_DATA_TEST_CASE(RunLargeUsecase, CLDirectConvolutionLayerFixture, framework::dataset::make("DataLayout", { DataLayout::NHWC }))) { // Validate output - validate(CLAccessor(_target), _reference, tolerance_fp32); + validate(CLAccessor(_target), _reference, tolerance_fp32, 0.f, tolerance_fp32_abs); } TEST_SUITE_END() // FP32 -- cgit v1.2.1