From d30405ac6eb38205676dfaa6e875b264caef431d Mon Sep 17 00:00:00 2001 From: Georgios Pinitas Date: Wed, 13 Jan 2021 14:42:54 +0000 Subject: Alter tolerance in QuantizationLayer to use int8_t for asymmetric signed Tolerance values passed to the validation process of QuantizationLayer for int8_t quantized types were in unsigned format leading in wrong interpretation of negative values. Thus, alter the tolerance type to use int8_t instead. Resolves: COMPMID-4090 Signed-off-by: Georgios Pinitas Change-Id: I82388a6e59cc91ca5093f0c665267b620523b122 Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4848 Reviewed-by: Giorgio Arena Comments-Addressed: Arm Jenkins Tested-by: Arm Jenkins --- tests/validation/NEON/QuantizationLayer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/validation/NEON/QuantizationLayer.cpp b/tests/validation/NEON/QuantizationLayer.cpp index 04b3a78972..36f2937cad 100644 --- a/tests/validation/NEON/QuantizationLayer.cpp +++ b/tests/validation/NEON/QuantizationLayer.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2020 Arm Limited. + * Copyright (c) 2017-2021 Arm Limited. * * SPDX-License-Identifier: MIT * @@ -97,7 +97,7 @@ FIXTURE_DATA_TEST_CASE(RunSmallQASYMM8Signed, NEQuantizationLayerQASYMM8SignedFi framework::dataset::make("QuantizationInfo", { QuantizationInfo(0.5f, 10) }))) { // Validate output - validate(Accessor(_target), _reference, tolerance_u8); + validate(Accessor(_target), _reference, tolerance_s8); } FIXTURE_DATA_TEST_CASE(RunSmallQASYMM16, NEQuantizationLayerQASYMM16Fixture, framework::DatasetMode::PRECOMMIT, combine(combine(combine(QuantizationSmallShapes, framework::dataset::make("DataType", DataType::F32)), @@ -140,7 +140,7 @@ FIXTURE_DATA_TEST_CASE(RunSmallQASYMM8Signed, NEQuantizationLayerQASYMM8SignedFi framework::dataset::make("QuantizationInfo", { QuantizationInfo(0.5f, 10) }))) { // Validate output - validate(Accessor(_target), _reference, tolerance_u8); + validate(Accessor(_target), _reference, tolerance_s8); } FIXTURE_DATA_TEST_CASE(RunSmallQASYMM16, NEQuantizationLayerQASYMM16Fixture, framework::DatasetMode::PRECOMMIT, combine(combine(combine(QuantizationSmallShapes, framework::dataset::make("DataType", DataType::F16)), -- cgit v1.2.1