From bbe4458f92585777198cbb34aef4c9b0998197c5 Mon Sep 17 00:00:00 2001 From: Sang-Hoon Park Date: Wed, 12 Feb 2020 13:10:02 +0000 Subject: COMPMID-3084: Fix padding value for Reduce MAX/MIN The correct minimum/maximum values of QASYMM8 is used for padding. Change-Id: Ia54e886e5acfd9c1236459b34d445bdc16446e3e Signed-off-by: Sang-Hoon Park Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/2721 Comments-Addressed: Arm Jenkins Reviewed-by: Michele Di Giorgio Tested-by: Arm Jenkins --- src/runtime/CL/functions/CLReductionOperation.cpp | 4 ++-- src/runtime/NEON/functions/NEReductionOperation.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/runtime/CL/functions/CLReductionOperation.cpp b/src/runtime/CL/functions/CLReductionOperation.cpp index e04982a315..fc902c4dfa 100644 --- a/src/runtime/CL/functions/CLReductionOperation.cpp +++ b/src/runtime/CL/functions/CLReductionOperation.cpp @@ -268,7 +268,7 @@ void CLReductionOperation::configure(ICLTensor *input, ICLTensor *output, unsign } case DataType::QASYMM8: { - pixelValue = PixelValue(255, input->info()->data_type(), input->info()->quantization_info()); + pixelValue = std::get<1>(get_min_max(input->info()->data_type())); break; } case DataType::QASYMM8_SIGNED: @@ -300,7 +300,7 @@ void CLReductionOperation::configure(ICLTensor *input, ICLTensor *output, unsign } case DataType::QASYMM8: { - pixelValue = PixelValue(0, input->info()->data_type(), input->info()->quantization_info()); + pixelValue = std::get<0>(get_min_max(input->info()->data_type())); break; } case DataType::QASYMM8_SIGNED: diff --git a/src/runtime/NEON/functions/NEReductionOperation.cpp b/src/runtime/NEON/functions/NEReductionOperation.cpp index 43205ef762..9d29ee007c 100644 --- a/src/runtime/NEON/functions/NEReductionOperation.cpp +++ b/src/runtime/NEON/functions/NEReductionOperation.cpp @@ -156,7 +156,7 @@ void NEReductionOperation::configure(ITensor *input, ITensor *output, unsigned i } case DataType::QASYMM8: { - pixelValue = PixelValue(255, input->info()->data_type(), input->info()->quantization_info()); + pixelValue = std::get<1>(get_min_max(input->info()->data_type())); break; } default: @@ -182,7 +182,7 @@ void NEReductionOperation::configure(ITensor *input, ITensor *output, unsigned i } case DataType::QASYMM8: { - pixelValue = PixelValue(0, input->info()->data_type(), input->info()->quantization_info()); + pixelValue = std::get<0>(get_min_max(input->info()->data_type())); break; } default: -- cgit v1.2.1