From 8b555e3fa1a19c6ccdb613b83bd532b3ce11cdd2 Mon Sep 17 00:00:00 2001 From: Manuel Bottini Date: Fri, 5 Feb 2021 12:53:41 +0000 Subject: Fix tolerance for NEON RNNLayer Use same absolute tolerance as in the GPU backend Change-Id: I92d8ce93ca189dad70dff6226b3b501b724cea33 Resolves: COMPMID-4239 Signed-off-by: Manuel Bottini Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5010 Reviewed-by: Giorgio Arena Comments-Addressed: Arm Jenkins Tested-by: Arm Jenkins --- tests/validation/NEON/RNNLayer.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/validation/NEON/RNNLayer.cpp b/tests/validation/NEON/RNNLayer.cpp index 7a3117a0b3..f8559ff88e 100644 --- a/tests/validation/NEON/RNNLayer.cpp +++ b/tests/validation/NEON/RNNLayer.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018 Arm Limited. + * Copyright (c) 2018-2021 Arm Limited. * * SPDX-License-Identifier: MIT * @@ -39,8 +39,9 @@ namespace validation { namespace { -RelativeTolerance tolerance_f32(0.001f); -RelativeTolerance tolerance_f16(half(0.1)); +RelativeTolerance tolerance_f32(0.001f); /**< Relative tolerance value for comparing reference's output against implementation's output for DataType:F32 */ +RelativeTolerance tolerance_f16(half(0.1)); /**< Relative tolerance value for comparing reference's output against implementation's output for DataType:F16 */ +constexpr float abs_tolerance_f16(0.02f); /**< Absolute tolerance value for comparing reference's output against implementation's output for DataType:F16 */ } // namespace TEST_SUITE(NEON) @@ -136,7 +137,7 @@ TEST_SUITE(FP16) FIXTURE_DATA_TEST_CASE(RunSmall, NERNNLayerFixture, framework::DatasetMode::ALL, combine(datasets::SmallRNNLayerDataset(), framework::dataset::make("DataType", DataType::F16))) { // Validate output - validate(Accessor(_target), _reference, tolerance_f16); + validate(Accessor(_target), _reference, tolerance_f16, 0.f, abs_tolerance_f16); } TEST_SUITE_END() // FP16 #endif /* __ARM_FEATURE_FP16_VECTOR_ARITHMETIC */ -- cgit v1.2.1