From 3dca91b84002f22f69ad5b9ddda0ce3579c4135b Mon Sep 17 00:00:00 2001 From: Georgios Pinitas Date: Tue, 13 Apr 2021 13:35:58 +0100 Subject: Disallow padding addittion when operating on CL images Importing buffer to OpenCL images requires compliance to strict HW requirements. Thus, disabling testing implicit padding when importing buffer to image. Resolves: COMPMID-4368 Signed-off-by: Georgios Pinitas Change-Id: Ib75499040b6dc02b435125674dc2cc91eacbf7ba Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/5416 Reviewed-by: Michele Di Giorgio Comments-Addressed: Arm Jenkins Tested-by: Arm Jenkins --- tests/validation/fixtures/GEMMFixture.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/validation/fixtures/GEMMFixture.h b/tests/validation/fixtures/GEMMFixture.h index 45516d4187..868eed4814 100644 --- a/tests/validation/fixtures/GEMMFixture.h +++ b/tests/validation/fixtures/GEMMFixture.h @@ -489,7 +489,7 @@ protected: ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS); - // TODO: remove if statement after COMPMID-4368 + // We do not pad when using image as it needs to comply to strict pitch alignment restrictions if(!rhs_info.export_to_cl_image) { add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst }); @@ -637,7 +637,7 @@ protected: ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS); - // TODO: remove if statement after COMPMID-4368 + // We do not pad when using image as it needs to comply to strict pitch alignment restrictions if(!rhs_info.export_to_cl_image) { add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst }); @@ -805,7 +805,7 @@ protected: ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS); - // TODO: remove if statement after COMPMID-4368 + // We do not pad when using image as it needs to comply to strict pitch alignment restrictions if(!rhs_info.export_to_cl_image) { add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst }); @@ -979,7 +979,7 @@ protected: ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS); - // TODO: remove if statement after COMPMID-4368 + // We do not pad when using image as it needs to comply to strict pitch alignment restrictions if(!rhs_info.export_to_cl_image) { add_padding_x({ &lhs, &rhs, &lhs_reshaped, &rhs_reshaped, &bias, &dst }); @@ -1148,7 +1148,7 @@ protected: ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS); - // TODO: remove if statement after COMPMID-4368 + // We do not pad when using image as it needs to comply to strict pitch alignment restrictions if(!rhs_info.export_to_cl_image) { add_padding_x({ &lhs, &rhs, &rhs_reshaped, &bias, &dst }); @@ -1313,7 +1313,7 @@ protected: ARM_COMPUTE_EXPECT(rhs.info()->is_resizable(), framework::LogLevel::ERRORS); ARM_COMPUTE_EXPECT(bias.info()->is_resizable(), framework::LogLevel::ERRORS); - // TODO: remove if statement after COMPMID-4368 + // We do not pad when using image as it needs to comply to strict pitch alignment restrictions if(!rhs_info.export_to_cl_image) { add_padding_x({ &lhs, &rhs, &rhs_reshaped, &bias, &dst }); -- cgit v1.2.1