From 35fcc4345b6468139a7199a48f75f70d19ea0d31 Mon Sep 17 00:00:00 2001 From: Georgios Pinitas Date: Thu, 26 Mar 2020 18:47:46 +0000 Subject: COMPMID-3248: Align SONAME and version in Version.h Signed-off-by: Georgios Pinitas Change-Id: Ia8911f559f0a33ccc62e42d47825577c998c85d7 Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/2937 Tested-by: Arm Jenkins Reviewed-by: Michele Di Giorgio Comments-Addressed: Arm Jenkins --- SConscript | 11 ++++++++++- arm_compute/core/Version.h | 6 ------ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/SConscript b/SConscript index f3ae8c3c86..b31f014db6 100644 --- a/SConscript +++ b/SConscript @@ -25,7 +25,10 @@ import re import subprocess VERSION = "v0.0-unreleased" -SONAME_VERSION="1.0.0" +LIBRARY_VERSION_MAJOR = 18 +LIBRARY_VERSION_MINOR = 1 +LIBRARY_VERSION_PATCH = 0 +SONAME_VERSION = str(LIBRARY_VERSION_MAJOR) + "." + str(LIBRARY_VERSION_MINOR) + "." + str(LIBRARY_VERSION_PATCH) Import('env') Import('vars') @@ -160,6 +163,12 @@ Default(generate_embed) if env["build"] == "embed_only": Return() +# Append version defines for semantic versioning +arm_compute_env.Append(CPPDEFINES = [('ARM_COMPUTE_VERSION_MAJOR', LIBRARY_VERSION_MAJOR), + ('ARM_COMPUTE_VERSION_MINOR', LIBRARY_VERSION_MINOR), + ('ARM_COMPUTE_VERSION_PATCH', LIBRARY_VERSION_PATCH)]) + + # Don't allow undefined references in the libraries: arm_compute_env.Append(LINKFLAGS=['-Wl,--no-undefined']) arm_compute_env.Append(CPPPATH =[Dir("./src/core/").path] ) diff --git a/arm_compute/core/Version.h b/arm_compute/core/Version.h index f88258f393..be3f0264bb 100644 --- a/arm_compute/core/Version.h +++ b/arm_compute/core/Version.h @@ -30,12 +30,6 @@ #define STRINGIFY2(s) #s #define STRINGIFY(s) STRINGIFY2(s) -/* Semantic versioning */ -#define ARM_COMPUTE_VERSION_MAJOR 18 -#define ARM_COMPUTE_VERSION_MINOR 0 -#define ARM_COMPUTE_VERSION_PATCH 0 -#define ARM_COMPUTE_VERSION_UNRELEASED 1 - #define ARM_COMPUTE_VERSION_STR \ STRINGIFY(ARM_COMPUTE_VERSION_MAJOR) \ "." STRINGIFY(ARM_COMPUTE_VERSION_MINOR) "." STRINGIFY(ARM_COMPUTE_VERSION_PATCH) -- cgit v1.2.1