From 2fe7d1cfb1929a65e1bb1e2edfda8e986ff10b96 Mon Sep 17 00:00:00 2001 From: Anthony Barbier Date: Fri, 15 Sep 2017 13:07:36 +0100 Subject: COMPMID-417 Update FIXME / INTERNAL_ONLY comments in files which need removing before releasing Change-Id: Iaebff59323758937326c3fbe8c80138ddbb57163 Reviewed-on: http://mpd-gerrit.cambridge.arm.com/87879 Tested-by: Kaizen Reviewed-by: Georgios Pinitas --- scripts/add_copyright.py | 1 + scripts/check_bad_style.sh | 1 + scripts/clang-tidy.h | 1 + scripts/clang_tidy_rules.py | 2 ++ scripts/fix_code_formatting.sh | 1 + scripts/format_doxygen.py | 1 + scripts/include_functions_kernels.py | 1 + tests/networks/AlexNetNetwork.h | 2 -- tests/networks/LeNet5Network.h | 2 -- tests/validation/CL/SYSTEM/AlexNet.cpp | 3 --- tests/validation/CL/SYSTEM/LeNet5.cpp | 3 --- tests/validation/NEON/SYSTEM/AlexNet.cpp | 3 --- tests/validation/NEON/SYSTEM/LeNet5.cpp | 3 --- 13 files changed, 8 insertions(+), 16 deletions(-) diff --git a/scripts/add_copyright.py b/scripts/add_copyright.py index 4a86497155..0c5b8f00cf 100755 --- a/scripts/add_copyright.py +++ b/scripts/add_copyright.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +#FIXME: Remove this file before the release import glob import os.path diff --git a/scripts/check_bad_style.sh b/scripts/check_bad_style.sh index d713122f2d..386824015f 100755 --- a/scripts/check_bad_style.sh +++ b/scripts/check_bad_style.sh @@ -1,4 +1,5 @@ #!/bin/bash +#FIXME: Remove this file before the release set -e diff --git a/scripts/clang-tidy.h b/scripts/clang-tidy.h index 7a629e6250..2c932ca3a4 100644 --- a/scripts/clang-tidy.h +++ b/scripts/clang-tidy.h @@ -1,4 +1,5 @@ #include +//FIXME: Remove this file before the release inline float16x8_t vrsqrtsq_f16 (float16x8_t, float16x8_t) { diff --git a/scripts/clang_tidy_rules.py b/scripts/clang_tidy_rules.py index d763a07079..61ada49149 100755 --- a/scripts/clang_tidy_rules.py +++ b/scripts/clang_tidy_rules.py @@ -1,4 +1,6 @@ #!/usr/bin/env python +#FIXME: Remove this file before the release + import os import re import sys diff --git a/scripts/fix_code_formatting.sh b/scripts/fix_code_formatting.sh index f64bdfb62a..ccda38abab 100755 --- a/scripts/fix_code_formatting.sh +++ b/scripts/fix_code_formatting.sh @@ -1,4 +1,5 @@ #!/bin/bash +#FIXME: Remove this file before the release ASTYLE_PARAMETERS=" --style=ansi \ --indent=spaces \ diff --git a/scripts/format_doxygen.py b/scripts/format_doxygen.py index da52f7e2a3..43c0ff49a3 100755 --- a/scripts/format_doxygen.py +++ b/scripts/format_doxygen.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3 +# FIXME: Remove before the release import os.path import re diff --git a/scripts/include_functions_kernels.py b/scripts/include_functions_kernels.py index 901a75e4d8..ab60343c4d 100755 --- a/scripts/include_functions_kernels.py +++ b/scripts/include_functions_kernels.py @@ -1,4 +1,5 @@ #!/usr/bin/env python3.5 +#FIXME: Remove this file before the release import glob import collections diff --git a/tests/networks/AlexNetNetwork.h b/tests/networks/AlexNetNetwork.h index d41e1b676c..1e99503792 100644 --- a/tests/networks/AlexNetNetwork.h +++ b/tests/networks/AlexNetNetwork.h @@ -378,7 +378,6 @@ public: } } -#ifdef INTERNAL_ONLY /** Fills the trainable parameters from binary files * * @param weights Files names containing the weights data @@ -405,7 +404,6 @@ public: { library->fill_layer_data(Accessor(input), name); } -#endif /* INTERNAL_ONLY */ /** Get the classification results. * diff --git a/tests/networks/LeNet5Network.h b/tests/networks/LeNet5Network.h index ed7ac18f40..f8aac30807 100644 --- a/tests/networks/LeNet5Network.h +++ b/tests/networks/LeNet5Network.h @@ -128,7 +128,6 @@ public: } } -#ifdef INTERNAL_ONLY /** Fills the trainable parameters from binary files * * @param weights Files names containing the weights data @@ -154,7 +153,6 @@ public: { library->fill_layer_data(Accessor(input), name); } -#endif /* INTERNAL_ONLY */ /** Get the classification results. * diff --git a/tests/validation/CL/SYSTEM/AlexNet.cpp b/tests/validation/CL/SYSTEM/AlexNet.cpp index d7dd62d4f2..75f8d19651 100644 --- a/tests/validation/CL/SYSTEM/AlexNet.cpp +++ b/tests/validation/CL/SYSTEM/AlexNet.cpp @@ -21,8 +21,6 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ -#ifdef INTERNAL_ONLY //FIXME Delete this file before the release - #include "arm_compute/runtime/CL/CLSubTensor.h" #include "arm_compute/runtime/CL/functions/CLActivationLayer.h" #include "arm_compute/runtime/CL/functions/CLConvolutionLayer.h" @@ -112,4 +110,3 @@ TEST_SUITE_END() } // namespace validation } // namespace test } // namespace arm_compute -#endif /* INTERNAL_ONLY */ diff --git a/tests/validation/CL/SYSTEM/LeNet5.cpp b/tests/validation/CL/SYSTEM/LeNet5.cpp index 6f68fa11a0..92dcdea500 100644 --- a/tests/validation/CL/SYSTEM/LeNet5.cpp +++ b/tests/validation/CL/SYSTEM/LeNet5.cpp @@ -21,8 +21,6 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ -#ifdef INTERNAL_ONLY //FIXME Delete this file before the release - #include "arm_compute/runtime/CL/functions/CLActivationLayer.h" #include "arm_compute/runtime/CL/functions/CLConvolutionLayer.h" #include "arm_compute/runtime/CL/functions/CLFullyConnectedLayer.h" @@ -97,4 +95,3 @@ TEST_SUITE_END() } // namespace validation } // namespace test } // namespace arm_compute -#endif /* INTERNAL_ONLY */ diff --git a/tests/validation/NEON/SYSTEM/AlexNet.cpp b/tests/validation/NEON/SYSTEM/AlexNet.cpp index 7a2b0d22b0..3fa19e4f03 100644 --- a/tests/validation/NEON/SYSTEM/AlexNet.cpp +++ b/tests/validation/NEON/SYSTEM/AlexNet.cpp @@ -21,8 +21,6 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ -#ifdef INTERNAL_ONLY //FIXME Delete this file before the release - #include "arm_compute/runtime/NEON/functions/NEActivationLayer.h" #include "arm_compute/runtime/NEON/functions/NEConvolutionLayer.h" #include "arm_compute/runtime/NEON/functions/NEDirectConvolutionLayer.h" @@ -113,4 +111,3 @@ TEST_SUITE_END() } // namespace validation } // namespace test } // namespace arm_compute -#endif /* INTERNAL_ONLY */ diff --git a/tests/validation/NEON/SYSTEM/LeNet5.cpp b/tests/validation/NEON/SYSTEM/LeNet5.cpp index 1642de8a97..95a82a6643 100644 --- a/tests/validation/NEON/SYSTEM/LeNet5.cpp +++ b/tests/validation/NEON/SYSTEM/LeNet5.cpp @@ -21,8 +21,6 @@ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ -#ifdef INTERNAL_ONLY //FIXME Delete this file before the release - #include "arm_compute/runtime/NEON/functions/NEActivationLayer.h" #include "arm_compute/runtime/NEON/functions/NEConvolutionLayer.h" #include "arm_compute/runtime/NEON/functions/NEFullyConnectedLayer.h" @@ -97,4 +95,3 @@ TEST_SUITE_END() } // namespace validation } // namespace test } // namespace arm_compute -#endif /* INTERNAL_ONLY */ -- cgit v1.2.1