COMPMID-2486: Remove disabled compiler warnings

Removed the following flags:
-Wno-format-nonliteral: This had a side effect on
Error.h that resulted in rewriting most of the macros. Since
I was at it I removed all the va_args in order to comply
with DCL50-CPP.
-Wno-deprecated-increment-bool
-Wno-vla-extension
-Wno-mismatched-tags
-Wno-redundant-move

Change-Id: I7c593854ecc3b7d595b8edcbd6a86d3c2563c6bd
Signed-off-by: Michalis Spyrou <michalis.spyrou@arm.com>
Reviewed-on: https://review.mlplatform.org/c/2069
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>

2 files changed, 5 insertions, 5 deletions

diff --git a/tests/framework/instruments/PMU.cpp b/tests/framework/instruments/PMU.cpp
index d0cacbba73..053c70a83f 100644
--- a/tests/framework/instruments/PMU.cpp
+++ b/tests/framework/instruments/PMU.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017 ARM Limited.
+ * Copyright (c) 2017-2019 ARM Limited.
  *
  * SPDX-License-Identifier: MIT
  *
@@ -76,7 +76,7 @@ void PMU::open(const perf_event_attr &perf_config)
     const int result = ioctl(_fd, PERF_EVENT_IOC_ENABLE, 0);
     if(result == -1)
     {
-        ARM_COMPUTE_ERROR("Failed to enable PMU counter: %d", errno);
+        ARM_COMPUTE_ERROR_VAR("Failed to enable PMU counter: %d", errno);
     }
 }
 
@@ -94,7 +94,7 @@ void PMU::reset()
     const int result = ioctl(_fd, PERF_EVENT_IOC_RESET, 0);
     if(result == -1)
     {
-        ARM_COMPUTE_ERROR("Failed to reset PMU counter: %d", errno);
+        ARM_COMPUTE_ERROR_VAR("Failed to reset PMU counter: %d", errno);
     }
 }
 } // namespace framework
diff --git a/tests/framework/instruments/PMU.h b/tests/framework/instruments/PMU.h
index 1dc41bef51..ef4a9a0dd0 100644
--- a/tests/framework/instruments/PMU.h
+++ b/tests/framework/instruments/PMU.h
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017-2018 ARM Limited.
+ * Copyright (c) 2017-2019 ARM Limited.
  *
  * SPDX-License-Identifier: MIT
  *
@@ -95,7 +95,7 @@ T PMU::get_value() const
 
     if(result == -1)
     {
-        ARM_COMPUTE_ERROR("Can't get PMU counter value: %d", errno);
+        ARM_COMPUTE_ERROR_VAR("Can't get PMU counter value: %d", errno);
     }
 
     return value;