diff options
author | Anthony Barbier <anthony.barbier@arm.com> | 2017-09-29 10:46:08 +0100 |
---|---|---|
committer | Anthony Barbier <anthony.barbier@arm.com> | 2018-11-02 16:35:24 +0000 |
commit | 144d2fff0e9a87050eafd856789683ab39f08eda (patch) | |
tree | b4ad1bb9466e9cb1e5ca6f107843472c60184c4d /tests/framework/instruments/PMU.h | |
parent | d6d57e2249cafb7dc4f150090fa9e3d46b71d20f (diff) | |
download | ComputeLibrary-144d2fff0e9a87050eafd856789683ab39f08eda.tar.gz |
COMPMID-417 Minor documentation fixes and error handling in instruments
Fixed some Doxygen issues in the introduction and tests sections
Switched MaliCounter to use ARM_COMPUTE_ERROR in order to get more context in case of failure
Switched to use ARM_COMPUTE_ERROR instead of ERROR_ON in PMU and MaliCounter so that checks work in release mode too. (As these checks are to detect platform issues rather than programming errors)
Change-Id: Ibbefa5a87d93c5c3aa5e190680052e4e99987dfe
Reviewed-on: http://mpd-gerrit.cambridge.arm.com/89662
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Tested-by: Kaizen <jeremy.johnson+kaizengerrit@arm.com>
Diffstat (limited to 'tests/framework/instruments/PMU.h')
-rw-r--r-- | tests/framework/instruments/PMU.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/tests/framework/instruments/PMU.h b/tests/framework/instruments/PMU.h index d51b2f8ae1..e0a1870539 100644 --- a/tests/framework/instruments/PMU.h +++ b/tests/framework/instruments/PMU.h @@ -86,8 +86,10 @@ T PMU::get_value() const T value{}; const ssize_t result = read(_fd, &value, sizeof(T)); - ARM_COMPUTE_ERROR_ON_MSG(result == -1, "Can't get PMU counter value: %d", errno); - ARM_COMPUTE_UNUSED(result); + if(result == -1) + { + ARM_COMPUTE_ERROR("Can't get PMU counter value: %d", errno); + } return value; } |