diff options
author | Giorgio Arena <giorgio.arena@arm.com> | 2021-01-05 09:46:16 +0000 |
---|---|---|
committer | Giorgio Arena <giorgio.arena@arm.com> | 2021-01-05 13:55:06 +0000 |
commit | b309fc249e4383b4d40ae03e377c3cbad3f9f5f7 (patch) | |
tree | c409dc7e0ce3080efc030d1082c60e451def97f1 /tests/AssetsLibrary.h | |
parent | 97b3f11a1655c05bedaf378f85f94cdccb1536ba (diff) | |
download | ComputeLibrary-b309fc249e4383b4d40ae03e377c3cbad3f9f5f7.tar.gz |
Fix uniform_real_distribution_fp16 warning and single Dimension increment
- Change uniform_real_distribution_fp16's arguments to float to avoid maybe-uninitialized warnings in half data type's copy constructor and converter
- Add increment method to Dimensions in order to avoid possible overflows when incrementing single dimensions
- Remove internal_only flag documentation
Resolves: COMPMID-4061
Change-Id: I7c50487193bd7b47b03d52fc595840c7df4e7104
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4760
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Diffstat (limited to 'tests/AssetsLibrary.h')
-rw-r--r-- | tests/AssetsLibrary.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/AssetsLibrary.h b/tests/AssetsLibrary.h index fdb05691ea..f44c554635 100644 --- a/tests/AssetsLibrary.h +++ b/tests/AssetsLibrary.h @@ -1,5 +1,5 @@ /* - * Copyright (c) 2017-2020 Arm Limited. + * Copyright (c) 2017-2021 Arm Limited. * * SPDX-License-Identifier: MIT * @@ -783,7 +783,7 @@ void AssetsLibrary::fill_tensor_uniform(T &&tensor, std::random_device::result_t case DataType::F16: { // It doesn't make sense to check [-inf, inf], so hard code it to a big number - arm_compute::utils::uniform_real_distribution_fp16 distribution_f16{ half(-100.f), half(100.f) }; + arm_compute::utils::uniform_real_distribution_fp16 distribution_f16{ -100.f, 100.f }; fill(tensor, distribution_f16, seed_offset); break; } @@ -980,7 +980,7 @@ void AssetsLibrary::fill_tensor_uniform(T &&tensor, std::random_device::result_t } case DataType::F16: { - arm_compute::utils::uniform_real_distribution_fp16 distribution_f16{ half(low), half(high) }; + arm_compute::utils::uniform_real_distribution_fp16 distribution_f16{ float(low), float(high) }; fill(tensor, distribution_f16, seed_offset); break; } |